Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerd integration: image delete should send image "untag" events and prometheus counters #43855

Closed
thaJeztah opened this issue Jul 21, 2022 · 0 comments · Fixed by #47555
Closed

containerd integration: image delete should send image "untag" events and prometheus counters #43855

thaJeztah opened this issue Jul 21, 2022 · 0 comments · Fixed by #47555
Labels
area/images area/metrics/prometheus area/metrics containerd-integration Issues and PRs related to containerd integration kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.
Projects
containerd integration

Comments

@thaJeztah
Copy link
Member

Description

The existing implementation sends untag

moby/daemon/images/image_delete.go

Line 106 in b94f715

i.LogImageEvent(imgID.String(), imgID.String(), "untag")

moby/daemon/images/image_delete.go

Line 169 in b94f715

i.LogImageEvent(imgID.String(), imgID.String(), "untag")

moby/daemon/images/image_delete.go

Line 255 in b94f715

i.LogImageEvent(imgID.String(), imgID.String(), "untag")

moby/daemon/images/image_delete.go

Line 106 in b94f715

i.LogImageEvent(imgID.String(), imgID.String(), "untag")

Prometheus counters;

moby/daemon/images/image_delete.go

Line 179 in b94f715

imageActions.WithValues("delete").UpdateSince(start)

@thaJeztah thaJeztah added kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. area/images containerd-integration Issues and PRs related to containerd integration labels Jul 21, 2022
This was referenced Apr 4, 2023
Merged
Closed
@rumpl rumpl mentioned this issue Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/images area/metrics/prometheus area/metrics containerd-integration Issues and PRs related to containerd integration kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.
Projects
No open projects
containerd integration
To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

c8d: Prometheus metrics rumpl/moby
1 participant
@thaJeztah