Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerd integration: image delete should send prometheus counters #45268

Closed
rumpl opened this issue Apr 4, 2023 · 0 comments · Fixed by #47555
Closed

containerd integration: image delete should send prometheus counters #45268

rumpl opened this issue Apr 4, 2023 · 0 comments · Fixed by #47555
Labels
area/images area/metrics/prometheus area/metrics containerd-integration Issues and PRs related to containerd integration kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.

Comments

@rumpl
Copy link
Member

rumpl commented Apr 4, 2023

Description

Description

The existing implementation sends prometheus counters;

moby/daemon/images/image_delete.go

Line 179 in b94f715

imageActions.WithValues("delete").UpdateSince(start)

@rumpl rumpl added kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. area/images containerd-integration Issues and PRs related to containerd integration labels Apr 4, 2023
@rumpl rumpl mentioned this issue Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/images area/metrics/prometheus area/metrics containerd-integration Issues and PRs related to containerd integration kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

c8d: Prometheus metrics rumpl/moby
2 participants
@rumpl @thaJeztah