New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for health start interval #45897
Comments
Ignore my previous comment (removed), it was before coffee |
This looks cool and useful, just leaving this here though: I looked through the PRs and didn't see anything about stack file support. Is this something that was overlooked by chance? |
@s4ke I added an item to the list |
FYI @cpuguy83, we won't be able to update the Compose to support the new |
If I'm understanding the above statements correctly, does this mean the |
@zamlz It should be available with the most recent dockerfile release. Set this at the top of your dockerfile:
However docker will not honor it until v25.0.0. |
@cpuguy83 interesting, so is there a point to using that then if docker won't honor it? I added the line on my end, and the error message is still the same. Follow up question, why does the latest |
What error message?
Because the dockerfile parser does support it and it will be embedded in the image config.
Only that it will be ready when docker v25 is released. |
@cpuguy83 I'm sorry, I didn't realize I never mentioned it in my first message. Please refer to the message below.
|
But in my system it does appear that the dockerfile parser does not support it. |
@zamlz What does this do for you?
|
@cpuguy83 that looks like it works fine.
But I forgot to mention an important thing about my environment. Because of bugs in the latest buildx, we have to use the legacy environment.(These bugs have been reported and fixed, they just haven't made it to upstream in distro package managers yet). Once we disable buildx and use the legacy builder, we run into issues.
|
Yes, the classic builder wouldn't support it (at least not for 24.0.x - for 25.0 I guess it still would have to be implemented, but given the deprecation, it's not decided yet). w.r.t. the syntax; # syntax=docker/dockerfile:1.6 Generally, I'd recommend using # syntax=docker/dockerfile:1
FROM yourimage:latest
# etc.. |
I see, thanks for the clarification @thaJeztah. Just curious, is there an expected version in which the legacy builder will be fully deprecated? Another quick question, is it recommended to add |
No, we haven't set a date for that. We still need to support the classic builder for Windows, as there's no support for native Windows containers/images yet in BuildKit. But consider it mostly on "life support"; there's no active development happening on the classic builder, so it'll mostly be (critical) bugfixes. That's not to say we fully froze it, so if it's possible to improve (or desirable for compatibility reasons), we may apply some patches, but if we do so, we'll look closely if it doesn't bring considerable maintenance-cost in doing so.
I think the docs could be somewhat clearer on this, but yes, I would recommend starting your Dockerfiles with a syntax directive (https://docs.docker.com/build/dockerfile/frontend/).
The default is to use the Dockerfile parser that's included with the BuildKit version that's included (compiled in) in the Daemon (e.g. for v24.0.5, the version of BuildKit included is; https://github.com/moby/moby/blob/v24.0.5/vendor.mod#L59). However, that version is not trivial to match with an exact version of the Dockerfile syntax (both are released from the BuildKit code repository, but follow their own release cycle). When For example: docker build -<<'EOF'
# syntax=docker/dockerfile:1
FROM scratch
EOF In the output, you can see
|
Description
The API was updated in #40894 but other changes are required:
start_interval
to healthcheck compose-spec/compose-spec#383Update docker/compose CLI after compose-go is merged(Compose maintainers want separate timing)After the 25.0 major release:
The text was updated successfully, but these errors were encountered: