Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack/make.sh: control explicitly whether or not to enable the journald logging driver #47770

Open
williamh opened this issue Apr 28, 2024 · 1 comment · May be fixed by #47789
Open

hack/make.sh: control explicitly whether or not to enable the journald logging driver #47770

williamh opened this issue Apr 28, 2024 · 1 comment · May be fixed by #47789
Labels
exp/intermediate kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny

Comments

@williamh
Copy link
Contributor

williamh commented Apr 28, 2024 •
edited by corhere

Description

Hi all, I am a docker maintainer on Gentoo Linux.
When docker is built from source, hack/make.sh always seems to look for libsystemd and link it if it is available.
See this bug for the details.
There should be a build option that controls whether or not this happens.
This issue exists in docker 26.1.0.
@williamh williamh added kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny status/0-triage labels Apr 28, 2024
@corhere corhere changed the title build tag to control whether or not docker links with libsystemd hack/make.sh: control explicitly whether or not to enable the journald logging driver May 1, 2024
@corhere
Copy link
Contributor

corhere commented May 1, 2024

There is a Go build tag: journald. Our build scripting happens to enable it whenever libsystemd is available at build time. PRs are welcome!

williamh added a commit to williamh/docker that referenced this issue May 2, 2024
@williamh
hack: explicitly control enabling the journald logging driver
fc6c657 
Without this, the dependency on systemd is said to be "automagic", which
can lead to breakage, for example, if a binary package of docker is
built on a system that has systemd installed then installed on a system
that does not have systemd installed.

for example: https://bugs.gentoo.org/914076

closes moby#47770
@williamh williamh linked a pull request May 2, 2024 that will close this issue
Open
williamh added a commit to williamh/docker that referenced this issue May 2, 2024
@williamh
hack: explicitly control enabling the journald logging driver
221133b 
Without this, the dependency on systemd is said to be "automagic", which
can lead to breakage, for example, if a binary package of docker is
built on a system that has systemd installed then installed on a system
that does not have systemd installed.

for example: https://bugs.gentoo.org/914076

closes moby#47770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/intermediate kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hack: explicitly control enabling the journald logging driver williamh/docker
2 participants
@williamh @corhere