Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch non-200 HTTP statuses on "docker pull" #50

Closed
chooper opened this issue Mar 12, 2013 · 3 comments
Closed

Catch non-200 HTTP statuses on "docker pull" #50

chooper opened this issue Mar 12, 2013 · 3 comments
Milestone
Launch

Comments

@chooper
Copy link
Contributor

chooper commented Mar 12, 2013

Currently, if you attempt to pull an existing image name with a non-existent revision, you receive the following error:

chooper@chimay:~/projects/docker/bin$ ./docker pull base:d34db33f
Downloading from base:d34db33f
Unpacking to base:d34db33f
curl: (6) Couldn't resolve host 'base'
base:d34db33f:e3b0c44298fc1c14
chooper@chimay:~/projects/docker/bin$ ./docker images
NAME                ID                               CREATED             PARENT
base:d34db33f       base:d34db33f:e3b0c44298fc1c14   2 minutes ago
@ghost ghost assigned chooper Mar 12, 2013
@chooper
Copy link
Contributor Author

chooper commented Mar 12, 2013

Turns out this is because non-200 status codes do not result in http.Get returning an error. Renaming this issue.

Ref: http://golang.org/pkg/net/http/#Client.Get

chooper pushed a commit to chooper/docker that referenced this issue Mar 12, 2013
Error gracefully when an image is not found on pull. Addresses moby#50 …
8e0986c 
…and comments from moby#49
chooper pushed a commit to chooper/docker that referenced this issue Mar 12, 2013
Add Download method for native Go downloading (to replace curl). Catc…
49554f4 
…h 404s.

Ref: moby#49, moby#50
chooper pushed a commit to chooper/docker that referenced this issue Mar 12, 2013
Add native Go downloading functionality with progress bar. Ref moby#49,
1bfd827 
moby#50
chooper pushed a commit to chooper/docker that referenced this issue Mar 12, 2013
Fix "no such image" bug in docker run, introduced last commit. Ref mo…
2feefb4 
…by#49,moby#50
@chooper
Copy link
Contributor Author

chooper commented Mar 12, 2013

This will be fixed by #49

@chooper
Copy link
Contributor Author

chooper commented Mar 13, 2013

This was closed by #49

@chooper chooper closed this as completed Mar 13, 2013
crosbymichael pushed a commit to crosbymichael/docker that referenced this issue Nov 20, 2013
@creack
Merge pull request moby#50 from crosbymichael/limit-dm
f6629bb 
Prohibit more than 42 layers in the core
@changwuf31 changwuf31 mentioned this issue Jan 10, 2014
Closed
@poe poe mentioned this issue Jan 23, 2014
Closed
@trkoch trkoch mentioned this issue Jan 27, 2014
Closed
@dduportal dduportal mentioned this issue May 4, 2014
Closed
@ztolley ztolley mentioned this issue May 29, 2014
Closed
@mayani mayani mentioned this issue Aug 14, 2014
Closed
runcom pushed a commit to runcom/docker that referenced this issue Jan 22, 2016
@rhatdan
Merge pull request moby#50 from runcom/fix-login-to-docker.io
f352734 
Fix login to docker.io on *-1.9 branches
@ocagdas ocagdas mentioned this issue Nov 14, 2016
Closed
@zerofoxtrots zerofoxtrots mentioned this issue Mar 30, 2017
Closed
rtyler pushed a commit to rtyler/docker that referenced this issue Feb 23, 2018
@charles-dyfis-net @carlossg
Avoid eval, shell-injection via JAVA_OPTS or JENKINS_OPTS
bbbb76d 
The intent of using eval when processing JAVA_OPTS or JENKINS_OPTS is to allow arguments with spaces to be passed through and parsed without the bugs given in [BashFAQ moby#50](http://mywiki.wooledge.org/BashFAQ/050). By using `eval`, however, the issues discussed in [BashFAQ moby#48](http://mywiki.wooledge.org/BashFAQ/048) are introduced.

Strings containing whitespace can be safely processed with `xargs`, which -- when not used with the non-POSIX extensions `-0` or `-d` -- follows shell quoting conventions in splitting its input stream into arguments.
AntaresS pushed a commit to AntaresS/moby that referenced this issue Sep 20, 2018
@andrewhsu
Merge pull request moby#50 from AntaresS/cherry-pick-moby
ea2e2c5 
[18.09] backport propagate the dockerd cgroup-parent config to buildkitd
ndeloof pushed a commit to ndeloof/docker that referenced this issue Aug 10, 2022
@rumpl
Merge pull request moby#50 from ndeloof/buildx
a7499e6 
let buildx know we support containerd snapshotter
crazy-max pushed a commit to crazy-max/moby that referenced this issue Sep 29, 2022
@rumpl @crazy-max
Merge pull request moby#50 from ndeloof/buildx
fa1972b 
let buildx know we support containerd snapshotter
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Launch
Development

No branches or pull requests
1 participant
@chooper