Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict characters on repository names #679

Closed
samalba opened this issue May 22, 2013 · 4 comments
Closed

Restrict characters on repository names #679

samalba opened this issue May 22, 2013 · 4 comments
Milestone
0.5.0

Comments

@samalba
Copy link
Contributor

samalba commented May 22, 2013

I propose to restrict characters to repository names to [0-9a-z-]. At least for the username. Then we can allow '_' for the repository name only.
@samalba samalba mentioned this issue May 22, 2013
Closed
@jpetazzo
Copy link
Contributor

FWIW, it looks like github allows [A-Za-z0-9_.-], and transforms all other
characters to "-".

@dhrp
Copy link
Contributor

dhrp commented May 22, 2013

I support using Github's naming convention. I think it is natural for people to use them, and it's what we already see. Other places where I see the same convention are apt, npm and pip

@shykes
Copy link
Contributor

shykes commented May 31, 2013

The registry API has been changed accordingly in df23a1e.

Now time to implement :)

@samalba
Copy link
Contributor Author

samalba commented Jul 16, 2013

Implemented already

@samalba samalba closed this as completed Jul 16, 2013
@valgogo valgogo mentioned this issue Feb 6, 2015
Merged
@4cm4k1 4cm4k1 mentioned this issue Jan 10, 2018
Closed
@FallenHoot FallenHoot mentioned this issue Apr 23, 2021
Closed
factotvm added a commit to factotvm/prr that referenced this issue Nov 29, 2022
@factotvm
Support dots in repo names
c10ae42 
Having a dot is supported in GitHub, while the `SHORT` regex is too
restrictive and disallows this. Support is added for repositories that
contain a period or full stop will work.

There is no definitive guide to allowed characters for GitHub
repositories, but you can piece together the allowed characters via
moby/moby#679 and desktop/desktop#3090.

Tests were also added that verified the allowed characters in the
repository name.
factotvm added a commit to factotvm/prr that referenced this issue Nov 29, 2022
@factotvm
Support dots in repo names
0599f59 
Having a dot is supported in GitHub, while the `SHORT` regex is too
restrictive and disallows this. Support is added for repositories that
contain a period or full stop.

There is no definitive guide to allowed characters for GitHub
repositories, but you can piece together the allowed characters via
moby/moby#679 and desktop/desktop#3090.

Tests were also added that verified the allowed characters in the
repository name.
@factotvm factotvm mentioned this issue Nov 29, 2022
Merged
factotvm added a commit to factotvm/prr that referenced this issue Nov 30, 2022
@factotvm
Support dots in repo names
13a222e 
Having a dot is supported in GitHub, while the `SHORT` regex is too
restrictive and disallows this. Support is added for repositories that
contain a period or full stop.

There is no definitive guide to allowed characters for GitHub
repositories, but you can piece together the allowed characters via
moby/moby#679 and desktop/desktop#3090.

Tests were also added that verified the allowed characters in the
repository name.
factotvm added a commit to factotvm/prr that referenced this issue Dec 2, 2022
@factotvm
Support dots in repo names
39fceeb 
Having a dot is supported in GitHub, while the `SHORT` regex is too
restrictive and disallows this. Support is added for repositories that
contain a period or full stop.

There is no definitive guide to allowed characters for GitHub
repositories, but you can piece together the allowed characters via
moby/moby#679 and desktop/desktop#3090.

Tests were also added that verified the allowed characters in the
repository name.
danobi pushed a commit to danobi/prr that referenced this issue Dec 2, 2022
@factotvm
Support dots in repo names (#21)
1063e7d 
Having a dot is supported in GitHub, while the `SHORT` regex is too
restrictive and disallows this. Support is added for repositories that
contain a period or full stop.

There is no definitive guide to allowed characters for GitHub
repositories, but you can piece together the allowed characters via
moby/moby#679 and desktop/desktop#3090.

Tests were also added that verified the allowed characters in the
repository name.
@drewbo drewbo mentioned this issue Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
4 participants
@shykes @jpetazzo @samalba @dhrp