Use "text/plain" content-type #10019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at does not. Signed-off-by: Jean-Paul Calderone <exarkun@twistedmatrix.com> Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@linux.com> (github: jfrazelle)
Signed-off-by: Jean-Paul Calderone <exarkun@twistedmatrix.com> Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@linux.com> (github: jfrazelle)
jessfraz
force-pushed
the
9954-text-plain-content-type
branch
from
63bb459
to
807f486
Compare
|
Docs LGTM |
|
LGTM |
| @@ -260,7 +260,7 @@ func (cli *DockerCli) monitorTtySize(id string, isExec bool) error { | |||
| sigchan := make(chan os.Signal, 1) | |||
| gosignal.Notify(sigchan, signal.SIGWINCH) | |||
| go func() { | |||
| for _ = range sigchan { | |||
| for range sigchan { | |||
There was a problem hiding this comment.
This is not valid for Go < 1.4. Maybe we could keep this the same as gccgo cannot even do the normal stuff let along this.
There was a problem hiding this comment.
I'm pretty sure I can into this too during some other PR. The latest gofmt wants this new format and drone fails because of it.
There was a problem hiding this comment.
we fixed drone :D, i will fix the commit
|
updated, I added a commit bc those other weren't mine idk if I should have just updated their commit |
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)
|
ummm drone? |
|
Drone is tired, too much work for a single node |
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Jan 12, 2015
Use "text/plain" content-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gofmt'd @exarkun commits from #9955Closes #9955
Fixes #9954