restrict filters server side in docker images

[vieux]

Unlike docker ps, docker images filters are restricted.

Filters are a great way to extend the filtering of the cli.
This change would be extremely useful in Swarm.

[vieux]

See docker-archive/classicswarm#249 for an example

[SvenDowideit]

you just changed some restrictions to constraints on the cli - where is the documentation telling users of this? :)

[thaJeztah]

I understand the use case, but want to point to a reason that accepting any filter could be troublesome #8777.

For that reason; perhaps this should be given another thought #928 Implement a 'clean' command so that uses can have a "safer" way to cleanup images and don't need to use the filters for that?

[thaJeztah]

Reading docker-archive/classicswarm#249; wouldn't that be something to use "meta-data" for? #9882, i.e. docker images -f label=node=fedora-1?

[vieux]

@SvenDowideit @thaJeztha I'll add the check back server side, so there will be no change for the user

[vieux]

Filters are already sent to the daemon, so it doesn't require any doc change

[thaJeztah]

I'll add the check back server side, so there will be no change for the user

👍 thanks

[vieux]

@thaJeztah @SvenDowideit updated, I added back the test

@crosbymichael @jfrazelle can you please take a look ?

[jessfraz]

LGTM

[thaJeztah]

I like this; having this check server-side makes more sense, so a nice improvement overall as well.

[jessfraz]

@thaJeztah I agree :D

[crosbymichael]

@vieux why is this more useful as a server side check? Are all filters done on the client or server?

[vieux]

@crosbymichael filters are done server side for docker images

[icecrime]

LGTM: server-side should be the source of truth for what's allowed.