Update the docs for --link accept container id #10135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolljt0725
force-pushed
the
update_link_docs
branch
from
7503d1d
to
c839613
Compare
| @@ -105,7 +105,7 @@ Finally, several networking options can only be provided when calling | |||
| [Configuring DNS](#dns) and | |||
| [How Docker networks a container](#container-networking) | |||
|
|
|||
| * `--link=CONTAINER_NAME:ALIAS` — see | |||
| * `--link=<CONTAINER_NAME|CONTAINER_ID>:ALIAS` — see | |||
There was a problem hiding this comment.
Perhaps this should be CONTAINER_NAME_or_ID to be (more) consistent with --net below on line 112?
(Occurs a couple more time in this document)
Signed-off-by: Lei Jitang <leijitang@huawei.com>
coolljt0725
force-pushed
the
update_link_docs
branch
from
c839613
to
7503738
Compare
|
update as @thaJeztah 's advice.Since GitHub/MarkDown will treat the |
|
Thanks (but can't check output on GitHub now from my phone) |
|
LGTM Ping @SvenDowideit @fredlf |
|
LGTM |
fredlf
pushed a commit
that referenced
this pull request
Jan 20, 2015
Update the docs for --link accept container id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lei Jitang leijitang@huawei.com