Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for HTTP proxies #10192

Merged
merged 1 commit into from
Jan 19, 2015

Conversation

icecrime
Copy link
Contributor

This provides documentation for #9951, already merged in master.

Replaces #10133

Signed-off-by: Arnaud Porterie <arnaud.porterie@docker.com>
@icecrime
Copy link
Contributor Author

Ping @jfrazelle!

@icecrime icecrime added this to the 1.5.0 milestone Jan 19, 2015
@jessfraz
Copy link
Contributor

Yay thank you! LGTM

@SvenDowideit
Copy link
Contributor

LGTM - @fredlf @jamtur01

@jamtur01
Copy link
Contributor

LGTM

jamtur01 added a commit that referenced this pull request Jan 19, 2015
@jamtur01 jamtur01 merged commit 826e0be into moby:master Jan 19, 2015
@icecrime
Copy link
Contributor Author

Well that was fast, thanks! 👍

@coolljt0725
Copy link
Contributor

@icecrime @jfrazelle I think we should add the help message in the CLI return message when client can't connect to the daemon due to the proxy and suggest then what to do.Maybe something like this FATA[0000] Error response from daemon: 404 page not found, if you set http_proxy or https_proxy, you can add /var/run/docker.sock to no_proxy and try again. Because most people don't view the docs often especially for those have the experience in using docker, and in this way they konw what to do when meet this situation.

@jessfraz
Copy link
Contributor

See the only problem is not everyone is going to want to setup a proxy so
pushing them towards that in an error message can be misleading... I'm not
sure exactly what to do tho because I agree many might not see the docs,
but I don't know how we can know for sure they want a proxy

On Mon, Jan 19, 2015 at 5:21 PM, leijitang notifications@github.com wrote:

@icecrime https://github.com/icecrime @jfrazelle
https://github.com/jfrazelle I think we should add the help message in
the CLI return message when client can't connect to the daemon due to the
proxy and suggest then what to do.Maybe something like this FATA[0000]
Error response from daemon: 404 page not found, if you set http_proxy or
https_proxy, you can add /var/run/docker.sock to no_proxy and try again.
Because most people don't view the docs often especially for those have the
experience in using docker, and in this way they konw what to do when meet
this situation.


Reply to this email directly or view it on GitHub
#10192 (comment).

@acgtyrant
Copy link

@jfrazelle I can tell you that many Chinese user will set the proxy environment because of the fucking GFW. So you can add the help message in the CLI, Thank you!

@jessfraz
Copy link
Contributor

We ended up adding a better fix
https://github.com/docker/docker/pull/10739/files

On Sunday, February 22, 2015, Isaac Ge notifications@github.com wrote:

@jfrazelle https://github.com/jfrazelle I can tell you that many
Chinese user will set the proxy environment because of the fucking GFW. So
you can add the help message in the CLI, Thank you!


Reply to this email directly or view it on GitHub
#10192 (comment).

@jessfraz
Copy link
Contributor

the one released today, it might have also been in 1.5.0 i cant remember
off the top of my head

On Thu, Apr 16, 2015 at 6:46 AM, Piotr Dobrogost notifications@github.com
wrote:

@jfrazelle https://github.com/jfrazelle
What version of docker is this patch going to be released in?


Reply to this email directly or view it on GitHub
#10192 (comment).

@piotr-dobrogost
Copy link

@jfrazelle

Do you refer to v1.6.0-rc7? If so then I should have been more precise and specify that I'm concerned with stable releases.

@thaJeztah
Copy link
Member

@piotr-dobrogost you're in luck; 1.6 was just pushed out the door

@icecrime icecrime deleted the 9951_client_proxy_doc branch July 15, 2015 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants