Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make debugs logs suck less. #10311

Merged
merged 1 commit into from
Jan 23, 2015
Merged

Make debugs logs suck less. #10311

merged 1 commit into from
Jan 23, 2015

Conversation

jessfraz
Copy link
Contributor

closes #10245
ping @crosbymichael

@jessfraz
Copy link
Contributor Author

there are also a line in archive/archive.go where the byte gets put in the logs like:
"[tar autodetect] n: [31 139 8 0 0 9 110 136 0 255] <--- idk who this is helping
but I know that is @unclejack's territory so I didn't touch it :)

@jessfraz
Copy link
Contributor Author

@dmcgowan @jlhawn how do you guys feel about is not logging this json string

@jessfraz
Make debugs logs suck less.
c49cd3d 
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)
@vieux
Copy link
Contributor

vieux commented Jan 23, 2015

"[tar autodetect] n: [31 139 8 0 0 9 110 136 0 255] is definitely not helping me.

LGTM

@jessfraz
Copy link
Contributor Author

@vieux I figured you could read bytes 😄

@crosbymichael
Copy link
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Jan 23, 2015
@crosbymichael
Merge pull request #10311 from jfrazelle/quiet-logs-registry
62c50ab 
Make debugs logs less verbose for registry
@crosbymichael crosbymichael merged commit 62c50ab into moby:master Jan 23, 2015
@crosbymichael crosbymichael deleted the quiet-logs-registry branch January 23, 2015 21:56
@unclejack
Copy link
Contributor

@jfrazelle @vieux Thanks, I'll take care of that now.

@SvenDowideit SvenDowideit mentioned this pull request Jan 27, 2015
Merged
@SvenDowideit SvenDowideit mentioned this pull request Feb 9, 2015
Closed
@SvenDowideit SvenDowideit mentioned this pull request Feb 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Noisy registry debug logs
4 participants
@jessfraz @vieux @crosbymichael @unclejack