Revert progressreader to not defer close #10327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When progress reader closes it overwrites the progress line with the full progress bar, replaces the completed message. Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
|
And what does this break? That change was made to fix an issue right? So reverting this would break something else? |
|
This was change was originally added on the panic fix which converted the progressreader to nopcloser when it passed it into an HTTP request. It was added to be more idiomatic about closing the progressreader. However when the progress reader is closed, it does a write out to the console progress line. Since it is deferred, it overwrites the complete message. To use defer the function scope would need to be decreased, however the close on progressreader does not do anything useful in this case (see other example where progressreader is not closed). |
|
Ok, thanks. LGTM |
|
LGTM |
1 similar comment
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Jan 26, 2015
Revert progressreader to not defer close
This was referenced Jan 26, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When progress reader closes it overwrites the progress line with the full progress bar, replaces the completed message.
Fixes #10325