Allow empty layer configs in manifests #10335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the V2 registry changes, images with no config could be pushed. This change fixes a regression that made those images not able to be pushed to a registry. Signed-off-by: Euan Kemp <euank@euank.com>
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
icecrime
pushed a commit
that referenced
this pull request
Jan 26, 2015
Allow empty layer configs in manifests
|
after the fact (no worries) but might be nice to have a test :P xoxo, |
|
jk there is one, ignore me |
|
@thaJeztah I really wanted to watch your linked video, but it's blocked in the United States :( Aren't we all citizens of the world? |
|
Oomph happens so me all the time as well, videos from the US being blocked in Europe. Net neutrality? Well, for fun this one should work http://bit.ly/1LcuSVy 😄 |
|
haha! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced in commit 188b56c (V2 registry).
Previous to that commit, the following command would work without error:
tar c --files-from /dev/null | docker import - "$USER/test"; docker push "$USER/test"After that commit, running the above results in the error:
FATA[0000] Error: Missing layer configurationThe imported image doesn't have to be empty to trigger this bug; it can be a rootfs with runnable static binaries and so on. It'll run fine with
docker run, just not be able to be used indocker push.This fix causes a nonexistent layer config to be treated as a "zero value" one instead of erroring out.
I verified that the added integ test did fail before making the graph manifest code change.