-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to load the json.gz file #10344
Change to load the json.gz file #10344
Conversation
0000000
to
b447107
Compare
follow on of @unclejack 's change. |
@fredlf @jamtur01 this makes a pretty massive difference to the docs site responsiveness. I'll update the 1.14 docs update PR once we merge this so we can get it out there asap. There are a couple more refinements that I'll work on over the next week or so, as we're still running with @mariusGundersen - can you confirm if http://dowideit-docs.s3-website-ap-southeast-2.amazonaws.com/ is better for your side of the world? I have not looked deeply enought into tipuesearch to get rid of the |
@@ -88,7 +91,6 @@ upload_current_documentation() { | |||
echo " to $dst" | |||
echo | |||
#s3cmd --recursive --follow-symlinks --preserve --acl-public sync "$src" "$dst" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this too?
LGTM |
@@ -100,6 +102,9 @@ upload_current_documentation() { | |||
echo "$run" | |||
echo "=======================" | |||
$run | |||
|
|||
# Make sure the search_content.json.gz file has the right content-encoding | |||
aws s3 cp --profile $BUCKET --cache-control "max-age=3600" --content-encoding="gzip" --acl public-read "site/search_content.json.gz" "$dst" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use the cache control variable so it will work for the master docs :D
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com> Docker-DCO-1.1-Signed-off-by: unclejack <unclejacksons@gmail.com> (github: SvenDowideit)
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au> Docker-DCO-1.1-Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au> (github: SvenDowideit)
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au> Docker-DCO-1.1-Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au> (github: SvenDowideit)
…_content when we have a search ?q= param Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au> Docker-DCO-1.1-Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au> (github: SvenDowideit)
6c2bff3
to
60089ac
Compare
LGTM. Thanks for handling this, @SvenDowideit! |
…_json_gz_file Change to load the json.gz file
…_the_json_gz_file Change to load the json.gz file (cherry picked from commit a79d363) Docker-DCO-1.1-Signed-off-by: Sven Dowideit <SvenDowideit@users.noreply.github.com> (github: SvenDowideit)
No description provided.