Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theadactyl as community manager #13371

Merged
merged 1 commit into from May 21, 2015
Merged

Add theadactyl as community manager #13371

merged 1 commit into from May 21, 2015

Conversation

theadactyl
Copy link
Contributor

Added Community Manager role to Org.Operators and added theadactyl as community manager

Added Community Manager role to Org.Operators and added theadactyl as community manager

Signed-off-by: Thea Lamkin <thea@docker.com>
@tianon
Copy link
Member

tianon commented May 20, 2015

Next time, please clone, amend, and force push your commit like @GordonTheTurtle suggested (#13370 (comment)) instead of opening a new PR. 😉

@crosbymichael
Copy link
Contributor

its just a bot, @GordonTheTurtle has no power over us

@jessfraz
Copy link
Contributor

the bots are here so i have friends, that is their sole purpose, LGTM

@theadactyl
Copy link
Contributor Author

thanks @tianon. had some git configuration to work through and got lazy. (shame)

@crosbymichael
Copy link
Contributor

@theadactyl first rule of community management, if something goes wrong, blame @tianon

@@ -319,6 +324,17 @@ made through a pull request.
# day of a new maintainer, the best advice should be "follow the C.M.'s example and you'll
# be fine".
"Chief Maintainer" = "crosbymichael"

# The community manager is responsible for serving the project community, including users,
# contributors and partners. This involves:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, nitpicking again; indentation of these lines and below looks "off"

@thaJeztah
Copy link
Member

..all those docs go unread 😢

added a note, other than that LGTM. Welcome Thea!

@theadactyl
Copy link
Contributor Author

@thaJeztah can you point out where the indentation is funky? I'm not seeing it :(

@thaJeztah
Copy link
Member

@theadactyl the first two lines of the comment block looked to be indented 1 space less than the rest. But my comment now makes that hard to see. 😇

I'm on mobile now, so hard to be sure

it's really a nit, so no worries if it stays in for now. Getting this merged is the important part :)

crosbymichael added a commit that referenced this pull request May 21, 2015
Add theadactyl as community manager
@crosbymichael crosbymichael merged commit 523d2f6 into moby:master May 21, 2015
@thaJeztah
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants