Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ip route showing mask-less IP addresses #1374

Merged
merged 3 commits into from Aug 5, 2013
Merged

Conversation

creack
Copy link
Contributor

@creack creack commented Aug 2, 2013

Sometimes ip route will show mask-less IPs, so net.ParseCIDR will fail. If it does we check if we can net.ParseIP, and fail only if we can't.
Fixes #1214
Fixes #362

steeve and others added 3 commits August 1, 2013 02:42
Sometimes `ip route` will show mask-less IPs, so net.ParseCIDR will fail. If it does we check if we can net.ParseIP, and fail only if we can't.
Fixes #1214
Fixes #362
@mhennings
Copy link
Contributor

+1

@vieux
Copy link
Contributor

vieux commented Aug 5, 2013

LGTM

@creack
Copy link
Contributor Author

creack commented Aug 5, 2013

/cc @crosbymichael

@crosbymichael
Copy link
Contributor

LGTM

creack added a commit that referenced this pull request Aug 5, 2013
- Runtime: Handle ip route showing mask-less IP addresses
@creack creack merged commit 2f1c05d into master Aug 5, 2013
@creack creack deleted the steeve-patch-1 branch August 5, 2013 21:13
@creack
Copy link
Contributor Author

creack commented Aug 5, 2013

thanks @steeve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker fails to parse ip route output Could not find a free IP address range for interface 'docker0'
6 participants