New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api/client] Fix build when context dir is symlink #15039
[api/client] Fix build when context dir is symlink #15039
Conversation
@jlhawn does this need to go into 1.8? |
@crosbymichael I guess it does: looks like a regression from the |
a44542f
to
77244c0
Compare
I've added a second commit with a test simple test case. With the test case commit alone the test case fails with the same error that @crosbymichael saw in #15037 but with the |
77244c0
to
f40b1a5
Compare
@jlhawn can you squash them together when it's ready? it will be easier to track/cherry-pick the changes. |
Symbolic links in the context directory path are now evaluated. Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
f40b1a5
to
01d570a
Compare
@calavera done. |
hmm, there are still some CI errors, but they seem unrelated. |
LGTM. |
LGTM |
[api/client] Fix build when context dir is symlink
hmm, this test still failed on Windows:
|
@jlhawn I'm not sure symlinks work on windows. We might need to extract that into platform specific files. /cc @jhowardmsft |
Yes, I believe that will be needed. |
@calavera @jhowardmsft I've opened #15060 to try and fix that test case on Windows. There's no need to use |
Symbolic links in the context directory path are now evaluated.
fixes #15037