cleanup vendoring of test deps

[jessfraz]

fixes the problems for #16229

ping @tianon @icecrime

[calavera]

is this print here on purpose?

[jessfraz]

yes so that those thinngs are in the array

On Tue, Sep 15, 2015 at 4:22 PM, David Calavera notifications@github.com
wrote:

In hack/.vendor-helpers.sh
#16294 (comment):

local imports=( $(
    for platform in "${dockerPlatforms[@]}"; do
        export GOOS="${platform%/*}";
        export GOARCH="${platform##*/}";
        for buildTags in "${buildTagCombos[@]}"; do

•           go list -e -tags "$buildTags" -f '{{join .Deps "\n"}}' "${packages[@]}"
  

•           go list -e -tags "$buildTags" -f '{{join .TestImports "\n"}}' "${packages[@]}"
  

•           pkgs=( $(go list -e -tags "$buildTags" -f '{{join .Deps "\n"}}' "${packages[@]}" | grep -E "^${PROJECT}" | grep -vE "^${PROJECT}/vendor" | sort -u) )
  

•           pkgs+=( ${packages[@]} )
  

•           testImports=( $(go list -e -tags "$buildTags" -f '{{join .TestImports "\n"}}' "${pkgs[@]}" | sort -u) )
  

•           printf '%s\n' "${testImports[@]}"
  

is this print here on purpose?

—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/16294/files#r39578200.

[calavera]

👌

[tianon]

Won't this only print the first item of the array as-is? Doesn't it need to be [*] to print all of them with just %s?

[jessfraz]

hmmm it worked for me locally :/

On Wed, Sep 16, 2015 at 3:48 PM, Tianon Gravi notifications@github.com
wrote:

In hack/.vendor-helpers.sh
#16294 (comment):

local imports=( $(
    for platform in "${dockerPlatforms[@]}"; do
        export GOOS="${platform%/*}";
        export GOARCH="${platform##*/}";
        for buildTags in "${buildTagCombos[@]}"; do

•           go list -e -tags "$buildTags" -f '{{join .Deps "\n"}}' "${packages[@]}"
  

•           go list -e -tags "$buildTags" -f '{{join .TestImports "\n"}}' "${packages[@]}"
  

•           pkgs=( $(go list -e -tags "$buildTags" -f '{{join .Deps "\n"}}' "${packages[@]}" | grep -E "^${PROJECT}" | grep -vE "^${PROJECT}/vendor" | sort -u) )
  

•           pkgs+=( ${packages[@]} )
  

•           testImports=( $(go list -e -tags "$buildTags" -f '{{join .TestImports "\n"}}' "${pkgs[@]}" | sort -u) )
  

•           printf '%s\n' "${testImports[@]}"
  

Won't this only print the first item of the array as-is? Doesn't it need
to be [*] to print all of them with just %s?

—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/16294/files#r39694927.

[tianon]

Oh interesting, printf appears to just "handle" this for us:

$ printf '%s\n' a b c
a
b
c

👍

[jessfraz]

You had me worried!

On Wednesday, September 16, 2015, Tianon Gravi notifications@github.com
wrote:

In hack/.vendor-helpers.sh
#16294 (comment):

local imports=( $(
    for platform in "${dockerPlatforms[@]}"; do
        export GOOS="${platform%/*}";
        export GOARCH="${platform##*/}";
        for buildTags in "${buildTagCombos[@]}"; do

•           go list -e -tags "$buildTags" -f '{{join .Deps "\n"}}' "${packages[@]}"
  

•           go list -e -tags "$buildTags" -f '{{join .TestImports "\n"}}' "${packages[@]}"
  

•           pkgs=( $(go list -e -tags "$buildTags" -f '{{join .Deps "\n"}}' "${packages[@]}" | grep -E "^${PROJECT}" | grep -vE "^${PROJECT}/vendor" | sort -u) )
  

•           pkgs+=( ${packages[@]} )
  

•           testImports=( $(go list -e -tags "$buildTags" -f '{{join .TestImports "\n"}}' "${pkgs[@]}" | sort -u) )
  

•           printf '%s\n' "${testImports[@]}"
  

Oh interesting, printf appears to just "handle" this for us:

$ printf '%s\n' a b cabc

[image: 👍]

—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/16294/files#r39696176.

[calavera]

LGTM

[icecrime]

LGTM