Add cluster advertise address to host address as default

[coolljt0725]

Signed-off-by: Lei Jitang leijitang@huawei.com
#16229 has add builtin nodes discovery,

since docker daemon could listen multiple address, we should make sure
the advertise address is listened by docker daemon.

ping @icecrime

[calavera]

/cc @icecrime, @abronan what do you think about this?

[abronan]

Makes sense but I feel quite uncomfortable with those default assumptions 😕. What if I give the wrong address to --cluster-advertise? It is going to assume that I want this address to be listened by the daemon even though I probably don't want to.

I much prefer giving the address to both -H and --cluster-advertise, at least I know what I get.

@icecrime WDYT?

[coolljt0725]

@abronan Another approach, if people give address to --cluster-advertise but forget to give it to -H, we should error out to tell user to give address to both just like etcd does

[abronan]

@coolljt0725 There is a related discussion ongoing in #17047 about the --cluster-advertise flag, should be worth adding your ideas here ;)

[cpuguy83]

I think it would be better to allow the admin to set these options rather than automatically trying to use cluster-address.

[thaJeztah]

Following the discussion above, I don't think there's consensus here, so I'll close this, but ping me if you think I closed prematurely

Thanks @coolljt0725 !