Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Make hostname not be FQDN thru the API #20196

Closed
wants to merge 1 commit into from
Closed

WIP: Make hostname not be FQDN thru the API #20196

wants to merge 1 commit into from

Conversation

thockin
Copy link
Contributor

@thockin thockin commented Feb 10, 2016

Fixes #14282

This is missing all docs and tests, but the approach needs validation.

This does not fix /etc/hostname, but truthfully, I'm OK with that, but could fix (where is that set?)

@GordonTheTurtle
Copy link

Job: Docker-PRs FAILED:

---
tainer 5d25e8994248
Successfully built fe805853d8e8

---> Making bundle: validate-dco (in bundles/1.11.0-dev/validate-dco)
These commits do not have a proper 'Signed-off-by:' marker:
 - f508b594c282b0d3d19f463adba448a6935298d4

Please amend each commit to include a properly formatted DCO marker.

Visit the following URL for information about the Docker DCO:
 https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work

Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Docker-PRs] $ /bin/sh -xe /tmp/hudson4032806003724937786.sh
+ set +x


---

@GordonTheTurtle
Copy link

Job: Docker-PRs-userns FAILED:

---
pg: keyserver timed out
gpg: keyserver receive failed: keyserver error
Removing intermediate container bd6d80d963b0
The command '/bin/sh -c apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 6084F3CF814B57C1CF12EFD515CF4D18AF4F7421' returned a non-zero code: 2
Unable to find image 'docker:b45dfef-userns' locally
Pulling repository docker.io/library/docker
Tag b45dfef-userns not found in repository docker.io/library/docker
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Docker-PRs-userns] $ /bin/sh -xe /tmp/hudson7084112557115435689.sh
+ set +x


---

@GordonTheTurtle
Copy link

Job: Docker-PRs-gccgo FAILED:

---
0c733448b5cea to sha256:619f6bc385fe60babf271163b1b2e19fd9cc06e2ef0c974a4b04743c9b744e52" 
time="2016-02-10T17:41:28Z" level=info msg="migrated layer 18a84d69a75d0c6246d0f3ed3c27e8aa601d73a884762ccc369c1008d8291eba to sha256:5f70bf18a086007016e948b04aed3b82103a36bea41755b6cddfaf10ace3c6ef" 
time="2016-02-10T17:41:28Z" level=info msg="migrated image 18a84d69a75d0c6246d0f3ed3c27e8aa601d73a884762ccc369c1008d8291eba to sha256:caf27bf2a5d82cdd31f8cdb95c437e46b64231ee7f7a1b0e3fdccb2981f3d246" 
--- FAIL: TestMigrateImages (0.00s)
    migratev1_test.go:182: invalid image mappings: expected map["18a84d69a75d0c6246d0f3ed3c27e8aa601d73a884762ccc369c1008d8291eba":"sha256:a488bec94bb96b26a968f913d25ef7d8d204d727ca328b52b4b059c7d03260b6" "3d52b43d612c4281acb919961e7aaa864302a48d6edcbf066fc0c733448b5cea":"sha256:ca406eaf9c26898414ff5b7b3a023c33310759d6203be0663dbf1b3a712f432d"], got map["18a84d69a75d0c6246d0f3ed3c27e8aa601d73a884762ccc369c1008d8291eba":"sha256:caf27bf2a5d82cdd31f8cdb95c437e46b64231ee7f7a1b0e3fdccb2981f3d246" "3d52
---

@GordonTheTurtle
Copy link

Job: Docker-PRs-experimental FAILED:

---
XPERIMENTAL is set: building experimental features

---> Making bundle: validate-dco (in bundles/1.11.0-dev/validate-dco)
These commits do not have a proper 'Signed-off-by:' marker:
 - f508b594c282b0d3d19f463adba448a6935298d4

Please amend each commit to include a properly formatted DCO marker.

Visit the following URL for information about the Docker DCO:
 https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work

Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Docker-PRs-experimental] $ /bin/sh -xe /tmp/hudson4248136755201526489.sh
+ set +x


---

@estesp
Copy link
Contributor

estesp commented Feb 10, 2016

I think the other PR is more palatable.. should we close this one?

@thockin
Copy link
Contributor Author

thockin commented Feb 10, 2016

yeah, i think so too.

@thockin thockin closed this Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker doesn't configure UTS namespace or /etc/hostname correctly
4 participants