Introduce dockercore/buildbase x64 base image

[icecrime]

Split the build Dockerfile in two, and extra the most stable pieces of the build environment into a dockercore/buildbase image.

The goal is to minimize build times for the most traditional use cases, while minimizing the dependencies to external services in our build process.

Before:

$ time docker build -t dev:master --no-cache .
[...]
Successfully built 3b3266760378

real    11m16.799s
user    0m4.772s
sys     0m0.672s

$ docker images
REPOSITORY                       TAG                 IMAGE ID            CREATED             SIZE
dev                              master              3b3266760378        8 minutes ago       2.267 GB

After:

$ time docker build -t dev:onbuildbase --no-cache .
[...]
Successfully built 91ead0f61278

real    3m44.476s
user    0m4.448s
sys     0m0.432s

$ docker images
REPOSITORY                       TAG                 IMAGE ID            CREATED             SIZE
dev                              usingbuildbase      91ead0f61278        53 seconds ago      2.267 GB
dockercore/buildbase             latest              3e4cb819ee01        9 minutes ago       1.822 GB

The right line between Dockerfile and Dockerfile.base is very much up for discussion. The rule of thumb for that initial proposal was to distinguish our content from third party content, under the assumption that we are more likely to update our own content throughout our pull requests.

A few more details about that new dockercore/buildbase image:

• I pushed one up to Docker Hub for people to try it out.
• If this gets merged, I'll enabled an Automated Build on Hub.
• Something to keep in mind: we might have to test manually any change to Dockerfile.base.

[mikedougherty]

just want to note that we have a CI job to test against different golang versions (https://jenkins.dockerproject.org/job/docker-golang-test-master/) which will need to be updated to comply with this change.

[unclejack]

@icecrime: It would be a good idea to have the frozen images in that base image as close as possible to the top to avoid triggering that download as much as possible. Having to download that during a build while connected to a slow network isn't fun.

[calavera]

this needs a rebase, ouch 😔

[thaJeztah]

@icecrime ^^

[icecrime]

Rebased! 👍

[tianon]

Do automated builds support using -f? Do we need this to live in a subdirectory somewhere for now to be able to setup an automated build on it?

[icecrime]

@tianon Yes I checked beforehand :-)

[tianon]

Oh, I had assumed that was just the context path; didn't realize they do some sensing to determine that it should be the "-f" argument. 👍

[icecrime]

@tianon Oops, actually you may be right, I just assumed from the UX...

[tianon]

😢

[icecrime]

Yeah it's just the context path 😿 Let me update that.

[icecrime]

Moved it back, got confirmation for team in charge of automated builds:

The ​_Dockerfile location_​ is split into a directory and a Dockerfile name. The directory becomes the build path and the Dockerfile is passed in with the equivalent of a -f using ​_docker-py_​.

So keeping it at the root will work 👍

[tianon]

Ah, neat; fair enough! 👍

LGTM

[tiborvass]

LGTM

[tonistiigi]

do we need to track the version here?

[icecrime]

Let me think about @tonistiigi comment above.

[icecrime]

Per @tonistiigi comment: added a pull command in the Makefile to ensure that we first check for the latest dockercore/buildbase before building.

[icecrime]

Ping @tianon @tiborvass @tonistiigi and all other people with "ti" in their name: PTAL!

[tiborvass]

Better :) re-LGTM

[icecrime]

Well, after discussing with @tonistiigi, I'm not sure we can merge this:

1. If we want people to get an up-to-date build, we need to ensure that a docker pull dockercore/buildbase is done as part of the build (for example in the Makefile).
2. If I do git checkout v1.10.0, I cannot reproduce a build unless I docker build -t dockercore/buildbase myself (and that's incompatible with the Makefile doing a docker pull).

I don't see a solution. We would need to version the dockercore/buildbase image, but that would have to be somewhat manual. 😞

[thaJeztah]

Can we pull by digest?

[icecrime]

@thaJeztah You don't know the digest until the automated build has run ;-)

[icecrime]

Closing this 😢 It's not going to make things better...