[carry 22894] Adding network filter to docker ps command

[thaJeztah]

closes #22894

- What I did

Carry of #22894, rebased, and adding filter by network id.

- How to verify it

docker run -d --net=bridge --name=onbridgenetwork busybox top
docker run -d --net=none --name=onnonenetwork busybox top

docker ps --filter network=bridge 

Output should show only the container with name "onbridgenetwork"

docker ps --filter network=bridge --filter network=none

Output should show both the containers "onbrigenetwork" and "onnonenetwork"

$ docker network inspect --format "{{.ID}}" net1
8c0b4110ae930dbe26b258de9bc34a03f98056ed6f27f991d32919bfe401d7c5

$ docker ps --filter network=8c0b4110ae930dbe26b258de9bc34a03f98056ed6f27f991d32919bfe401d7c5

Output should only show the onbridgenetwork container

- Description for the changelog

Add support for docker ps --filter network=<network-id | network-name> to filter containers by the network(s) they're connected to.

[thaJeztah]

ping @vdemeester @cpuguy83; moved this back to code-review because of the latest changes

[thaJeztah]

Hm, guess Windows doesn't have "bridge" network, so I should make that dependent on platform

10:34:51 ----------------------------------------------------------------------
10:34:51 FAIL: docker_cli_ps_test.go:808: DockerSuite.TestPsListContainersFilterNetwork
10:34:51 
10:34:51 docker_cli_ps_test.go:810:
10:34:51     // create a container
10:34:51     runSleepingContainer(c, "--net=bridge", "--name=onbridgenetwork")
10:34:51 C:/gopath/src/github.com/docker/docker/pkg/integration/dockerCmd_utils.go:42:
10:34:51     c.Assert(err, check.IsNil, check.Commentf(quote+"%v"+quote+" failed with errors: %s, %v", strings.Join(args, " "), out, err))
10:34:51 ... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc08247e980)} ("exit status 125")
10:34:51 ... "run -d --net=bridge --name=onbridgenetwork busybox sleep 240" failed with errors: D:\CI\CI-cbfb366\binary\docker.exe: Error response from daemon: network bridge not found.
10:34:51 See 'D:\CI\CI-cbfb366\binary\docker.exe run --help'.
10:34:51 , exit status 125

[cpuguy83]

Yeah, windows has a "nat" network.

[thaJeztah]

I'll just create a custom network, then I don't have to make platform-specific changes

[thaJeztah]

Well, I'll be. Doesn't windows support dashes in network names?

15:27:19 FAIL: docker_cli_ps_test.go:808: DockerSuite.TestPsListContainersFilterNetwork
15:27:19 
15:27:19 docker_cli_ps_test.go:810:
15:27:19     // create a network, and some containers
15:27:19     dockerCmd(c, "network", "create", "network-a")
15:27:19 C:/gopath/src/github.com/docker/docker/pkg/integration/dockerCmd_utils.go:42:
15:27:19     c.Assert(err, check.IsNil, check.Commentf(quote+"%v"+quote+" failed with errors: %s, %v", strings.Join(args, " "), out, err))
15:27:19 ... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc082400180)} ("exit status 1")
15:27:19 ... "network create network-a" failed with errors: Error response from daemon: plugin not found
15:27:19 , exit status 1
15:27:19 

@msabansal is that a known issue?

let me rename that network for now

[thaJeztah]

Opened an issue for the Windows issue; #23314

[vdemeester]

Let's add a TODO and a requires DaemonIsLinux on that then 👼

[thaJeztah]

Or make it conditional, and filter on "nat" for windows. Didn't come round to do this yet, will try to do so later today

[thaJeztah]

@vdemeester disabled the test for now on Windows, and added a TODO

[vdemeester]

LGTM 🐮

[cpuguy83]

LGTM

[cpuguy83]

And win2lin finished but didn't notify. Merging.

[cpuguy83]

Actually, let me set it to docs-review :)

[vdemeester]

docs LGTM 🐮

[thaJeztah]

author LGTM