Adding force to node rm #25159
Adding force to node rm #25159
Conversation
| Error response from daemon: rpc error: code = 9 desc = node swarm-node-03 is not down and can't be removed | ||
|
|
||
| If a node is compromised, starts misbehaving, or access to it is lost such that a | ||
| clean shutdown of the node is not possible, you can use the force option. |
There was a problem hiding this comment.
Currently, you can't force removal of a manager, right?
There was a problem hiding this comment.
Correct. Added text to say that managers have to be demoted before they can be removed.
|
@sfsmithcha help on docs? 😞 |
| @@ -30,6 +31,20 @@ Example output: | |||
| $ docker node rm swarm-node-02 | |||
| Node swarm-node-02 removed from swarm | |||
|
|
|||
| This command will only remove nodes that are in the down state. Attempting to remove | |||
There was a problem hiding this comment.
Typical convention is: "Removes nodes that are in the down state from the swarm."
|
Design LGTM |
diogomonica
force-pushed
the
adding-force-to-node-remove
branch
4 times, most recently
from
bd80b92
to
66291fe
Compare
diogomonica
force-pushed
the
adding-force-to-node-remove
branch
2 times, most recently
from
61ede8e
to
440b788
Compare
| }, | ||
| } | ||
| flags := cmd.Flags() | ||
| flags.BoolVar(&opts.force, "force", false, "Force remove an active node.") |
There was a problem hiding this comment.
There shouldn't be a period at the end of this flag description.
Signed-off-by: Diogo Monica <diogo.monica@gmail.com>
diogomonica
force-pushed
the
adding-force-to-node-remove
branch
from
440b788
to
a327c23
Compare
|
|
||
| ```bash | ||
| $ docker node rm swarm-node-03 | ||
| Error response from daemon: rpc error: code = 9 desc = node swarm-node-03 is not down and can't be removed |
There was a problem hiding this comment.
We noticed that the use of
```bash
here causes the text after the apostrophe in the error message to get highlighted.
ping @thaJeztah - should we drop the "bash" formatting? I'm sure there are other places where we have this problem, and just haven't noticed.
There was a problem hiding this comment.
Yes, that's a known problem; we mark them as bash to make the highlighting more predictable, but basically many of our examples are combined "bash" / "shell" and "output". The output should just be plain text.
We tried putting it in a separate code-block but that's equally bad (they appear as two separate blocks in the layout).
Removing the bash hint is not solution; doing so will make the highlightjs "guess" what language it should pick; and in this case, it thinks it's Ruby, which looks even worse:
In this case; changing to formal English (cannot) perhaps? 😄
|
LGTM pending an answer on the docs formatting question. |
|
LGTM, this one is blocking #25096 |
|
LGTM, we should look at the highlighting in general, so no blocker |
Added a
--forceflag todocker node rmthat forces node removal independent of current state./cc @aaronlehmann