Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support multiple service IDs on "docker service ps" #25234
- What I did
This fix tries to address the issue raised in #25228 to support multiple service IDs on
- How I did it
Multiple IDs are allowed with
- How to verify it
A test has been added to cover the changes.
- Description for the changelog
Support multiple service IDs on "docker service ps"
- A picture of a cute animal (not mandatory but encouraged)
This fix fixes #25228.
Signed-off-by: Yong Tang email@example.com
referenced this pull request
Jul 29, 2016
functionally, it makes sense to have an option to show tasks for multiple services; I'm a bit in doubt what the best approach is. For example,
@thaJeztah I'm not sure I would compare it to docker ps (on single engine). Maybe it is closer indeed to "ps" on the previous swarm where you got all containers and indeed used filter if needed.
One thing I am not sure is the return code when some (or all of the) terms searched does not found service with matched ID or matched name prefix. The currently PR will return empty result (but no error). Should we return error on it? Would like to hear suggestions on this scenario.
Yes, but we've specified an algorithm that should work in most cases.
It must be modified here, since ambiguous lookups are no longer an error but a merge.