Email deprecation for step 6 of tutorial #25896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oskar Niburski <oskarniburski@gmail.com>
| @@ -72,13 +72,12 @@ If you don't already have a terminal open, open one now: | |||
|
|
|||
| The format for the login command is: | |||
|
|
|||
| docker login --username=yourhubusername --email=youremail@company.com | |||
| docker login --username=yourhubusername --password=fake123 | |||
There was a problem hiding this comment.
I think we'd better remove the --password flag here; in general, it's not recommended to used that option, because it'll leak your password (e.g. In your shell history)
|
/ping @raksonibs |
Signed-off-by: Oskar Niburski <oskarniburski@gmail.com>
|
LGTM 🐸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Updated Trivial Aspect of Tutorial for Login Changes. Email is Deprecated in Step 6 of tutorial.
- How I did it
Removed
--emailcomments.- How to verify it
Please try login commands without --email and with following tutorial procedure.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
http://i.imgur.com/911OR75.gifv