Auto-detect node IP address #27910
Merged
Auto-detect node IP address #27910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/needs-vendoring
status/1-design-review
and removed
status/0-triage
status/needs-vendoring
labels
|
don't forget to update the docs (CLI reference, API reference), and API changes |
|
Design LGTM |
dperny
force-pushed
the
node_ip_in_raft
branch
2 times, most recently
from
950a1be
to
b35e550
Compare
|
Rebased and dropped vendoring commit because docker now has swarmkit vendored far enough. |
|
LGTM |
|
@mstanleyjones Do we need docs review on reference docs updates? This is a small API/CLI change |
dperny
force-pushed
the
node_ip_in_raft
branch
from
b35e550
to
0bbc870
Compare
|
Squashed 2 commits into 1. |
|
@aluzzardi yes, but for small changes, it's usually @vdemeester and myself doing the docs review, and we'll ping @mstanleyjones if assistance is needed 😅 |
thaJeztah
requested changes
Nov 2, 2016
| @@ -4465,6 +4465,7 @@ List nodes | |||
| }, | |||
| "Status": { | |||
| "State": "ready" | |||
| @@ -4556,6 +4557,7 @@ Return low-level information on the node `id` | |||
| }, | |||
| "Status": { | |||
| "State": "ready" | |||
| @@ -89,6 +89,7 @@ Example output: | |||
| }, | |||
| "Status": { | |||
| "State": "ready" | |||
Manager now auto-detects the address that an agent connects to the cluster from and stores it. This is useful for many kinds of internal cluster management tools. Signed-off-by: Drew Erny <drew.erny@docker.com>
dperny
force-pushed
the
node_ip_in_raft
branch
from
0bbc870
to
9bcf623
Compare
|
@thaJeztah Fixed JSON errors. Thanks for the catch. |
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
Auto-detect node IP address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
The IP address that an agent connects to the manager from is recorded, stored, and exposed through the API. This is useful for many kinds of internal cluster management tools. The field is
Node.Status.Addr.- How I did it
Change in swarmkit to support this behavior, then update docker to expose this in its api
- How to verify it
docker node inspectnow shows node address underStatus, both with and without--pretty.- Description for the changelog
Autodetect, store, and expose node IP address as seen by the manager.
- A picture of a cute animal (not mandatory but encouraged)
This bird, the violet-backed starling, is purple.