Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for new prune commands #28096

Merged
merged 1 commit into from Nov 7, 2016

Conversation

albers
Copy link
Member

@albers albers commented Nov 5, 2016

This adds bash completion for

  • docker system prune
  • docker container prune
  • docker image prune
  • docker volume prune
  • docker network prune

Ref: #26108, #27525

Signed-off-by: Harald Albers <github@albersweb.de>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM

@vdemeester vdemeester merged commit afb1119 into moby:master Nov 7, 2016
@albers albers deleted the completion-prune branch November 7, 2016 12:02
@albers
Copy link
Member Author

albers commented Nov 7, 2016

@vdemeester Please schedule for 1.13.0

@thaJeztah thaJeztah added this to the 1.13.0 milestone Nov 7, 2016
@thaJeztah
Copy link
Member

@albers I added the PR's to the milestone. Note that the initial RC for 1.13 will be branched from master, so cherry-picking is only needed for changes after the code freeze (after 1.13.0-rc1 is released)

@albers
Copy link
Member Author

albers commented Nov 7, 2016

@thaJeztah Thanks!
I took the omnipresence of 1.13.0 labels for a sign that the release branch already exists.

@thaJeztah
Copy link
Member

@albers adding the milestones never hurts, I regularly add them also for easier tracking in future :-) (e.g. to find out which release a PR was included in)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants