Remove docker stack ps -a to match removal of docker service/node ps -a
#29716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps -a` In moby#28507 and moby#28885, `docker service/node ps -a` has been removed so that information about slots are show up even without `-a` flag. The output of `docker stack ps` reused the same output as `docker service/node ps`. However, the `-a` was still there. It might make sense to remove `docker stack ps -a` as well to bring consistency with `docker service/node ps`. This fix is related to moby#28507, moby#28885, and moby#25983. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
vdemeester
added
process/cherry-pick
status/2-code-review
and removed
status/0-triage
labels
vdemeester
approved these changes
Dec 27, 2016
|
Merging since consistency is good here. |
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
Remove `docker stack ps -a` to match removal of `docker service/node ps -a`
albers
added a commit
to albers/docker-cli
that referenced
this pull request
Aug 23, 2017
This option was removed in moby/moby#28885. Bash completion was only updated for `service ps`, though. See moby/moby#29716 for the corresponding docs change. Signed-off-by: Harald Albers <github@albersweb.de>
albers
added a commit
to albers/docker-cli
that referenced
this pull request
Aug 23, 2017
This option was removed in moby/moby#28885. Bash completion was only updated for `service ps`, though. See moby/moby#29716 for the corresponding docs change. Signed-off-by: Harald Albers <github@albersweb.de>
andrewhsu
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Aug 30, 2017
This option was removed in moby/moby#28885. Bash completion was only updated for `service ps`, though. See moby/moby#29716 for the corresponding docs change. Signed-off-by: Harald Albers <github@albersweb.de> Upstream-commit: 328f4fbf060bb2728b2320839d000c66bb6002f4 Component: cli
riyazdf
pushed a commit
to riyazdf/cli
that referenced
this pull request
Sep 18, 2017
This option was removed in moby/moby#28885. Bash completion was only updated for `service ps`, though. See moby/moby#29716 for the corresponding docs change. Signed-off-by: Harald Albers <github@albersweb.de>
riyazdf
pushed a commit
to riyazdf/cli
that referenced
this pull request
Sep 18, 2017
This option was removed in moby/moby#28885. Bash completion was only updated for `service ps`, though. See moby/moby#29716 for the corresponding docs change. Signed-off-by: Harald Albers <github@albersweb.de>
riyazdf
pushed a commit
to riyazdf/cli
that referenced
this pull request
Sep 18, 2017
This option was removed in moby/moby#28885. Bash completion was only updated for `service ps`, though. See moby/moby#29716 for the corresponding docs change. Signed-off-by: Harald Albers <github@albersweb.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #28507 and #28885,
docker service/node ps -ahas been removed so that information about slots are showed up even without-aflag.The output of
docker stack psreused the same output asdocker service/node ps. However, the-awas still there. It might make sense to removedocker stack ps -aas well to bring consistency withdocker service/node ps.This fix is related to #28507, #28885, and #25983.
Signed-off-by: Yong Tang yong.tang.github@outlook.com