Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --prune to stack deploy #31302

Merged
merged 1 commit into from Mar 15, 2017

Conversation

@dnephin
Copy link
Member

commented Feb 23, 2017

Fixes #29898

cc @vdemeester

Description for changelog

+ Add `--prune` option to `docker stack deploy` [#31302](https://github.com/docker/docker/pull/31302)
Copy link
Member

left a comment

Desgin LGTM.
Code looks good, gotta try this out tomorrow but 👍

@@ -42,7 +48,12 @@ func (c *FakeCli) Out() *command.OutStream {
return command.NewOutStream(c.out)
}

// In returns thi input stream the cli will use

This comment has been minimized.

Copy link
@vdemeester
@thaJeztah

This comment has been minimized.

Copy link
Member

commented Feb 23, 2017

Should we have a --remove-orphans alias to make adoption easier for those that are used to docker-compose?

@vieux

This comment has been minimized.

Copy link
Collaborator

commented Feb 23, 2017

should docker system prune prune stacks as well ?

@thaJeztah

This comment has been minimized.

Copy link
Member

commented Feb 23, 2017

Perhaps documenting it somewhere (some sort of migration guide) could work

@dnephin

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2017

Should we have a --remove-orphans alias to make adoption easier for those that are used to docker-compose?

I think there are enough CLI differences already that no one should expect the same flags.

should docker system prune prune stacks as well ?

There is no object on the server yet, so I don't think so. We don't have prune for services either, right?

@dnephin dnephin force-pushed the dnephin:purge-orphaned-services branch from c7027d5 to 3f81c44 Mar 3, 2017
@cpuguy83

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2017

Design OK.

@dnephin

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2017

Moved to code review

Copy link
Contributor

left a comment

LGTM

Copy link
Member

left a comment

LGTM 🐸

@vdemeester

This comment has been minimized.

Copy link
Member

commented Mar 12, 2017

/cc @thaJeztah for docs review

@thaJeztah

This comment has been minimized.

Copy link
Member

commented Mar 13, 2017

@dnephin dnephin force-pushed the dnephin:purge-orphaned-services branch from 3f81c44 to e47cdae Mar 13, 2017
@dnephin

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2017

I think this part of the command line reference is generated now, but I've added them anyway.

Copy link
Member

left a comment

LGTM, thanks!

@thaJeztah

This comment has been minimized.

Copy link
Member

commented Mar 14, 2017

may need to be squashed though 😇

Add to command line reference.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin dnephin force-pushed the dnephin:purge-orphaned-services branch from e47cdae to 644fd80 Mar 14, 2017
@dnephin

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2017

rebased

@thaJeztah

This comment has been minimized.

Copy link
Member

commented Mar 15, 2017

All green 👍

@thaJeztah thaJeztah merged commit b0d1936 into moby:master Mar 15, 2017
6 checks passed
6 checks passed
dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 31749 has succeeded
Details
janky Jenkins build Docker-PRs 40342 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 430 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 11419 has succeeded
Details
z Jenkins build Docker-PRs-s390x 299 has succeeded
Details
@GordonTheTurtle GordonTheTurtle added this to the 17.04.0 milestone Mar 15, 2017
@thaJeztah thaJeztah modified the milestones: 17.05.0, 17.04.0 Mar 15, 2017
@dnephin dnephin deleted the dnephin:purge-orphaned-services branch Mar 15, 2017
dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.