New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --prune to stack deploy #31302

Merged
merged 1 commit into from Mar 15, 2017

Conversation

@dnephin
Member

dnephin commented Feb 23, 2017

Fixes #29898

cc @vdemeester

Description for changelog

+ Add `--prune` option to `docker stack deploy` [#31302](https://github.com/docker/docker/pull/31302)
@vdemeester

Desgin LGTM.
Code looks good, gotta try this out tomorrow but 👍

Show outdated Hide outdated cli/internal/test/cli.go
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Feb 23, 2017

Member

Should we have a --remove-orphans alias to make adoption easier for those that are used to docker-compose?

Member

thaJeztah commented Feb 23, 2017

Should we have a --remove-orphans alias to make adoption easier for those that are used to docker-compose?

@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Feb 23, 2017

Collaborator

should docker system prune prune stacks as well ?

Collaborator

vieux commented Feb 23, 2017

should docker system prune prune stacks as well ?

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Feb 23, 2017

Member

Perhaps documenting it somewhere (some sort of migration guide) could work

Member

thaJeztah commented Feb 23, 2017

Perhaps documenting it somewhere (some sort of migration guide) could work

@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin

dnephin Mar 3, 2017

Member

Should we have a --remove-orphans alias to make adoption easier for those that are used to docker-compose?

I think there are enough CLI differences already that no one should expect the same flags.

should docker system prune prune stacks as well ?

There is no object on the server yet, so I don't think so. We don't have prune for services either, right?

Member

dnephin commented Mar 3, 2017

Should we have a --remove-orphans alias to make adoption easier for those that are used to docker-compose?

I think there are enough CLI differences already that no one should expect the same flags.

should docker system prune prune stacks as well ?

There is no object on the server yet, so I don't think so. We don't have prune for services either, right?

@cpuguy83

This comment has been minimized.

Show comment
Hide comment
@cpuguy83

cpuguy83 Mar 7, 2017

Contributor

Design OK.

Contributor

cpuguy83 commented Mar 7, 2017

Design OK.

@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin

dnephin Mar 7, 2017

Member

Moved to code review

Member

dnephin commented Mar 7, 2017

Moved to code review

@cpuguy83

LGTM

@vdemeester

LGTM 🐸

@vdemeester

This comment has been minimized.

Show comment
Hide comment
@vdemeester

vdemeester Mar 12, 2017

Member

/cc @thaJeztah for docs review

Member

vdemeester commented Mar 12, 2017

/cc @thaJeztah for docs review

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah
Member

thaJeztah commented Mar 13, 2017

@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin

dnephin Mar 13, 2017

Member

I think this part of the command line reference is generated now, but I've added them anyway.

Member

dnephin commented Mar 13, 2017

I think this part of the command line reference is generated now, but I've added them anyway.

@thaJeztah

LGTM, thanks!

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Mar 14, 2017

Member

may need to be squashed though 😇

Member

thaJeztah commented Mar 14, 2017

may need to be squashed though 😇

Add --prune to stack deploy.
Add to command line reference.

Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin

dnephin Mar 14, 2017

Member

rebased

Member

dnephin commented Mar 14, 2017

rebased

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Mar 15, 2017

Member

All green 👍

Member

thaJeztah commented Mar 15, 2017

All green 👍

@thaJeztah thaJeztah merged commit b0d1936 into moby:master Mar 15, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 31749 has succeeded
Details
janky Jenkins build Docker-PRs 40342 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 430 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 11419 has succeeded
Details
z Jenkins build Docker-PRs-s390x 299 has succeeded
Details

@GordonTheTurtle GordonTheTurtle added this to the 17.04.0 milestone Mar 15, 2017

@thaJeztah thaJeztah modified the milestones: 17.05.0, 17.04.0 Mar 15, 2017

@dnephin dnephin deleted the dnephin:purge-orphaned-services branch Mar 15, 2017

dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment