Join GitHub today
Add Support for Service Task Logs #32015
This PR probably needs a docs update too. I'm gonna wait until it passes design review before I update the docs
- What I did
Added search by task if a service wasn't found.
- How I did it
- How to verify it
- Description for the changelog
Will task ids and service ids ever overlap?
Could we just accept all the ids without adding a new flag?
I'm not sure the right options for the CLI UI. What I've presented is my best effort as to what I think is correct. Ideally I'd like to support any arbitrary combination of task/service/node logs to reflect what the swarmkit GRPC can do with log selectors. However, that concept DOES NOT map to the existing REST API paradigm, and, by extension, to the CLI.
Someone is going to come in here, like the last PR about this, and suggest that we do like filters or whatever and I agree with you but I'm really boxed in by the REST paradigm, which is not conducive to arbitrary selectors like GRPC API is. We'd need an extra API endpoint that does have the format
I'm going to alter the CLI to have the pattern
referenced this pull request
Mar 28, 2017
updated api/swagger.yml to reflect task logs. The updated API documentation may not be totally correct (it is copied from service logs, which is also not totally correct for pre-existing reasons) and will need to be updated again before service logs are moved out of experimental.
Apr 3, 2017
Apr 4, 2017
6 checks passed
ping @dperny erm;
Looks like the
Also, can you open a pull request to add a mention of this endpoint to the API changelog; https://github.com/docker/docker/blob/master/docs/api/version-history.md#v129-api-changes ?