remove --init-path from client #32470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I think we should keep the |
|
Yes, the boolean should still be there to enable/disable on a per run basis.... |
runcom
force-pushed
the
remove-init-client
branch
from
4741ff1
to
422b795
Compare
|
updated to leave |
runcom
force-pushed
the
remove-init-client
branch
from
422b795
to
89f3d00
Compare
runcom
changed the title
|
ugh, needs a rebase @runcom 😢 |
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
|
rebased! |
runcom
force-pushed
the
remove-init-client
branch
from
89f3d00
to
a18d103
Compare
|
@thaJeztah shouldn't we deprecate instead of removing ? |
|
@vieux we could keep the flag; point is that the flag never was intended to be on docker run --init-path=/hello/world --init -dit --name foobar busybox
docker inspect foobar | grep world
<empty>/ # docker top foobar
PID USER TIME COMMAND
227 root 0:00 /dev/init -- sh
252 root 0:00 sh |
|
ping @thaJeztah where are we on this? |
|
Anyone? 👼 |
mlaventure
approved these changes
Apr 25, 2017
thaJeztah
added a commit
to thaJeztah/docker-py
that referenced
this pull request
Apr 10, 2019
This option was never functional, and was not intended to be added to the "container create" API, so let's remove it, because it has been removed in Docker 17.05, and was broken in versions before that; see - moby/moby#32355 --init-path does not seem to work - moby/moby#32470 remove --init-path from client Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/docker.github.io
that referenced
this pull request
Apr 11, 2019
This option was never functional, and was not intended to be added to the "container create" API, so let's remove it, because it has been removed in Docker 17.05, and was broken in versions before that; see - docker/docker-py#2309 Remove init_path from create - moby/moby#32355 --init-path does not seem to work - moby/moby#32470 remove --init-path from client Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/docker.github.io
that referenced
this pull request
Apr 11, 2019
This option was never functional, and was not intended to be added to the "container create" API, so let's remove it, because it has been removed in Docker 17.05, and was broken in versions before that; see - docker/docker-py#2309 Remove init_path from create - moby/moby#32355 --init-path does not seem to work - moby/moby#32470 remove --init-path from client Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
bermudezmt
pushed a commit
to docker/docs
that referenced
this pull request
Apr 12, 2019
* compose-file: remove reference to custom init path This option was never functional, and was not intended to be added to the "container create" API, so let's remove it, because it has been removed in Docker 17.05, and was broken in versions before that; see - docker/docker-py#2309 Remove init_path from create - moby/moby#32355 --init-path does not seem to work - moby/moby#32470 remove --init-path from client Signed-off-by: Sebastiaan van Stijn <github@gone.nl> * Update index.md
tcaiazzi
pushed a commit
to tcaiazzi/docker-py
that referenced
this pull request
Mar 4, 2020
This option was never functional, and was not intended to be added to the "container create" API, so let's remove it, because it has been removed in Docker 17.05, and was broken in versions before that; see - moby/moby#32355 --init-path does not seem to work - moby/moby#32470 remove --init-path from client Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #32355
@justincormack @thaJeztah PTAL
Signed-off-by: Antonio Murdaca runcom@redhat.com