container: update real-time resources

[runcom]

CPU real-time period and runtime are actually sent as part of an update
command via the cli:

https://github.com/docker/cli/blob/master/cli/command/container/update.go#L20-L21

This patch makes update effective because, until now, those settings
weren't actually updated in a container.

Tested in on a real-time kernel, this fixes the issue. Can't add a test
though as I don't think CI has rt kernels enabled.

Reproducer on a rt kernel:

root@xxx ~]# docker run -p 9090:9090 -itd --cpu-rt-runtime=790000
--ulimit rtprio=99 --cap-add=sys_nice mytest
[root@xxx ~]# docker exec -it awesome_edison /bin/bash
[root@451a1aa4fd46 /]# cat /sys/fs/cgroup/cpu/cpu.rt_runtime_us
790000

[root@xxx ~]# docker update --cpu-rt-runtime=810000 awesome_edison
awesome_edison
[root@xxx ~]# docker exec -it awesome_edison /bin/bash
[root@451a1aa4fd46 /]# cat /sys/fs/cgroup/cpu/cpu.rt_runtime_us
790000

[root@xxx ~]# echo 811000 >
/sys/fs/cgroup/cpu/system.slice/docker-451a1aa4fd468f3b67783c23d00e70558183456c775119484319c3f17d49e409.scope/cpu.rt_runtime_us
[root@xxx ~]# docker exec -it awesome_edison /bin/bash
[root@451a1aa4fd46 /]# cat /sys/fs/cgroup/cpu/cpu.rt_runtime_us
811000

Signed-off-by: Antonio Murdaca runcom@redhat.com

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[cpuguy83]

LGTM

[runcom]

wait, this is still missing containerd changes...

[runcom]

Sorry for the confusion, I had time now to create containerd/containerd#1031 - after that's merged I'll re-vendor containerd here for this PR

[runcom]

@mlaventure @cpuguy83 good to go now

[mlaventure]

@runcom looks like the default spec generation needs to be updated. Process is now a pointer.

[runcom]

Hopefully fixed

[mlaventure]

Looks like oom_score_adj is broken now:

17:33:07 ----------------------------------------------------------------------
17:33:07 FAIL: docker_cli_run_test.go:3830: DockerSuite.TestRunWithOomScoreAdj
17:33:07 
17:33:07 docker_cli_run_test.go:3837:
17:33:07     c.Fatalf("Expected oom_score_adj set to %q, got %q instead", expected, oomScoreAdj)
17:33:07 ... Error: Expected oom_score_adj set to "642", got "0" instead
17:33:07 
17:33:07 
17:33:07 ----------------------------------------------------------------------

[runcom]

Looks like oom_score_adj is broken now:

bumped runc to take care of it I guess

[runcom]

alright, runc is still way to old wrt runtime-spec, I'm bumping it again...

[runcom]

looks like spec must be updated in containerd v0.2.x to use new runc....

[mlaventure]

ping @runcom

12:36:24 ----------------------------------------------------------------------
12:36:24 FAIL: docker_cli_run_unix_test.go:564: DockerSuite.TestRunWithBlkioWeight
12:36:24 
12:36:24 docker_cli_run_unix_test.go:569:
12:36:24     c.Assert(strings.TrimSpace(out), checker.Equals, "300")
12:36:24 ... obtained string = "500"
12:36:24 ... expected string = "300"
12:36:24 
12:36:25 
12:36:25 ----------------------------------------------------------------------

[thaJeztah]

ping @runcom what's the status on this one? Looks like it needs a rebase at least 😅

[coolljt0725]

ping @runcom what's the status on this pr? needs a rebase

[runcom]

looks like spec must be updated in containerd v0.2.x to use new runc....

need to take care of that but it wasn't trivial as many stuff have alerady been updated there...I'll re-work on this asap

[runcom]

@coolljt0725 @thaJeztah @mlaventure updated

[coolljt0725]

LGTM

[yongtang]

LGTM