-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing API documentation for DataPathAddr #33941
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COmmit 0307fe1 added a new `DataPathAddr` property to the swarm/init and swarm/join endpoints. This property was not yet added to the documentation. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
LGTM, thanks for adding it |
sigh; looks like there were issues with Docker Hub search we need to rewrite that test to a unit test, no need to test if Docker Hub is working
|
LGTM |
author LGTM |
thaJeztah
commented
Jul 11, 2017
@@ -26,6 +26,8 @@ keywords: "API, Docker, rcli, REST, documentation" | |||
the daemon. This endpoint is experimental and only available if the daemon is started with experimental features | |||
enabled. | |||
* `GET /images/(name)/get` now includes an `ImageMetadata` field which contains image metadata that is local to the engine and not part of the image config. | |||
* `POST /swarm/init` now accepts a `DataPathAddr` property to set the IP-address or network interface to use for data traffic | |||
* `POST /swarm/join` now accepts a `DataPathAddr` property to set the IP-address or network interface to use for data traffic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, put it under the wrong API version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0307fe1 added
a new
DataPathAddr
property to the swarm/init and swarm/joinendpoints. This property was not yet added to the
documentation.
Relates to #32717
ping @fcrisciani PTAL