Fix issue of ExitCode and PID not show up in Task.Status.ContainerStatus #36150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongtang
force-pushed
the
36139-ContainerStatus
branch
from
9515b43
to
ba16c81
Compare
This fix tries to address the issue raised in 36139 where ExitCode and PID does not show up in Task.Status.ContainerStatus The issue was caused by `json:",omitempty"` in PID and ExitCode which interprate 0 as null. This is confusion as ExitCode 0 does have a meaning. This fix removes `json:",omitempty"` in ExitCode and PID, but changes ContainerStatus to pointer so that ContainerStatus does not show up at all if no content. If ContainerStatus does have a content, then ExitCode and PID will show up (even if they are 0). This fix fixes 36139. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
36139-ContainerStatus
branch
from
ba16c81
to
9247e09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix tries to address the issue raised in #36139 where ExitCode and PID does not show up in Task.Status.ContainerStatus
The issue was caused by
json:",omitempty"in PID and ExitCode which interprate 0 as null.This is confusing as ExitCode 0 does have a meaning.
This fix removes
json:",omitempty"in ExitCode and PID, but changes ContainerStatus to pointer so that ContainerStatus does not show up at all if no content. If ContainerStatus does have a content, then ExitCode and PID will show up (even if they are 0).This fix fixes #36139.
Signed-off-by: Yong Tang yong.tang.github@outlook.com