Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump libnetwork to fix panic on concurrent read/write to a map #36840

Merged
merged 1 commit into from Apr 13, 2018
Merged

Bump libnetwork to fix panic on concurrent read/write to a map #36840

merged 1 commit into from Apr 13, 2018

Conversation

cpuguy83
Copy link
Member

@cpuguy83 cpuguy83 commented Apr 12, 2018 •
edited by thaJeztah

Full diff
moby/libnetwork@5c1218c...c15b372

Fixes ##36814 -- panic on concurrent read/write to a map.

Changes included:

@cpuguy83 cpuguy83 requested a review from tianon as a code owner April 12, 2018 15:24
@cpuguy83 cpuguy83 requested a review from mavenugo April 12, 2018 15:24
@yongtang
Copy link
Member

@cpuguy83 Title libcontainerd -> libnetwork?

@cpuguy83
Bump libnetwork commit
248aed5 
Full diff
moby/libnetwork@5c1218c...c15b372

Fixes a panic on concurrent read/write to a map.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83
Copy link
Member Author

lol yes.

@cpuguy83 cpuguy83 changed the title Bump libcontainerd commit Bump libnetwork commit Apr 12, 2018
@cpuguy83
Copy link
Member Author

Fixed the commit message.

yongtang
yongtang approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

vdemeester
vdemeester approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@codecov
Copy link

codecov bot commented Apr 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@6f4bf56). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #36840   +/-   ##
=========================================
  Coverage          ?   35.27%           
=========================================
  Files             ?      614           
  Lines             ?    45687           
  Branches          ?        0           
=========================================
  Hits              ?    16118           
  Misses            ?    27432           
  Partials          ?     2137

@AkihiroSuda AkihiroSuda merged commit 544ec09 into moby:master Apr 13, 2018
@thaJeztah thaJeztah mentioned this pull request Apr 14, 2018
Closed
@thaJeztah thaJeztah changed the title Bump libnetwork commit Bump libnetwork to fix panic on concurrent read/write to a map Apr 14, 2018
@thaJeztah thaJeztah mentioned this pull request Apr 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@yongtang yongtang yongtang approved these changes

@tianon tianon Awaiting requested review from tianon tianon is a code owner

@mavenugo mavenugo Awaiting requested review from mavenugo

Assignees
No one assigned
Labels
area/networking status/4-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cpuguy83 @yongtang @vdemeester @thaJeztah @AkihiroSuda @GordonTheTurtle