Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/term add build tag for netbsd #36887

Merged
merged 1 commit into from Apr 20, 2018
Merged

pkg/term add build tag for netbsd #36887

merged 1 commit into from Apr 20, 2018

Conversation

alexjomin
Copy link
Contributor

@alexjomin alexjomin commented Apr 18, 2018

- What I did
Adding netbsd compatibility to the package pkg/term

- How I did it
Added a netbsd build tag

- How to verify it
Import the package and build with the GOOS=netbsd var

- Description for the changelog
Adding netbsd compatibility to the package pkg/term

Signed-off-by: Alexandre Jomin <alexandrejomin@gmail.com>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM 🐯

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anusha-ragunathan
Copy link
Contributor

Issue tracking TestAPISwarmServicesCreate failure: #36903

@codecov
Copy link

codecov bot commented Apr 20, 2018

Codecov Report

Merging #36887 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #36887     +/-   ##
=========================================
- Coverage   34.95%   34.76%   -0.2%     
=========================================
  Files         614      614             
  Lines       45638    46568    +930     
=========================================
+ Hits        15955    16188    +233     
- Misses      27592    28260    +668     
- Partials     2091     2120     +29

@thaJeztah thaJeztah merged commit d6706dd into moby:master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants