Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for RingLogger's ring buffer #37084

Merged
merged 1 commit into from
May 17, 2018
Merged

Update documentation for RingLogger's ring buffer #37084

merged 1 commit into from
May 17, 2018

Conversation

nwneisen
Copy link
Contributor

@nwneisen nwneisen commented May 17, 2018

fixes #36556

- What I did
Update RingLogger documentation to correctly describe the ring buffer's behavior.

- How I did it
Examined code to make sure documentation changes were accurate before modifying the comments.

- How to verify it
Read documentation before an after.

- Description for the changelog
Update documentation for RingLogger's ring buffer.

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Nick Neisen nwneisen@gmail.com

Signed-off-by: Nick Neisen <nwneisen@gmail.com>
Copy link
Member

@boaz0 boaz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Thanks!

@thaJeztah
Copy link
Member

14:40:41 WARNING: deadline exceeded by linter gosimple (try increasing --deadline)
14:40:42 WARNING: deadline exceeded by linter interfacer (try increasing --deadline)

@thaJeztah
Copy link
Member

Janky failing on #36501

16:24:25 FAIL: docker_api_swarm_service_test.go:33: DockerSwarmSuite.TestAPIServiceUpdatePort
16:24:25 
16:24:25 [d7e5a5aa6fbf2] waiting for daemon to start
16:24:25 [d7e5a5aa6fbf2] daemon started
16:24:25 
16:24:25 docker_api_swarm_service_test.go:39:
16:24:25     waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1)
16:24:25 docker_utils_test.go:435:
16:24:25     c.Assert(v, checker, args...)
16:24:25 ... obtained int = 0
16:24:25 ... expected int = 1
16:24:25 
16:24:25 [d7e5a5aa6fbf2] exiting daemon
16:24:36


16:48:56 FAIL: docker_cli_swarm_test.go:1605: DockerSwarmSuite.TestSwarmPublishDuplicatePorts
16:48:56 
16:48:56 [d43f82da09302] waiting for daemon to start
16:48:56 [d43f82da09302] daemon started
16:48:56 
16:48:56 docker_cli_swarm_test.go:1613:
16:48:56     // make sure task has been deployed.
16:48:56     waitAndAssert(c, defaultReconciliationTimeout, d.CheckActiveContainerCount, checker.Equals, 1)
16:48:56 docker_utils_test.go:435:
16:48:56     c.Assert(v, checker, args...)
16:48:56 ... obtained int = 0
16:48:56 ... expected int = 1
16:48:56 
16:48:56 [d43f82da09302] exiting daemon
16:48:58 

@thaJeztah
Copy link
Member

PowerPC also failing on a flaky test #32673

16:03:37 FAIL: docker_api_swarm_test.go:296: DockerSwarmSuite.TestAPISwarmLeaderElection
16:03:37 
16:03:37 [d7bf8b29ac3f7] waiting for daemon to start
16:03:37 [d7bf8b29ac3f7] daemon started
16:03:37 
16:03:37 [d669ec800b3d9] waiting for daemon to start
16:03:37 [d669ec800b3d9] daemon started
16:03:37 
16:03:37 [df97f96ba8668] waiting for daemon to start
16:03:37 [df97f96ba8668] daemon started
16:03:37 
16:03:37 [d7bf8b29ac3f7] exiting daemon
16:03:37 assertion failed: error is not nil: Error response from daemon: rpc error: code = DeadlineExceeded desc = context deadline exceeded
16:03:37 [d669ec800b3d9] exiting daemon
16:03:37 [df97f96ba8668] exiting daemon
16:03:53 

@anusha-ragunathan
Copy link
Contributor

LGTM

@anusha-ragunathan anusha-ragunathan merged commit 5969877 into moby:master May 17, 2018
@nwneisen nwneisen deleted the update-ring-buffer-documents branch May 18, 2018 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ring buffer for RingLogger dose not work as it documented
5 participants