Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to containerd v1.1.1-rc.1 #37312

Merged
merged 1 commit into from Jun 20, 2018
Merged

Update to containerd v1.1.1-rc.1 #37312

merged 1 commit into from Jun 20, 2018

Conversation

thaJeztah
Copy link
Member

Full diff: containerd/containerd@395068d...cbef570

Relevant change is; containerd/containerd#2395 [release/1.1] update cri to v1.0.3, which brings in these changes: containerd/cri@v1.0.2...v1.0.3

@thaJeztah
Update to containerd v1.1.1-rc.1
83ec91a 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah requested a review from tianon as a code owner June 19, 2018 18:20
@thaJeztah
Copy link
Member Author

ping @dmcgowan @justincormack PTAL

@dmcgowan
Copy link
Member

LGTM

@thaJeztah
Copy link
Member Author

PowerPC failing on a flaky test; https://jenkins.dockerproject.org/job/Docker-PRs-powerpc/10250/console (tracked through #37277)

19:43:44 FAIL: docker_cli_daemon_test.go:1800: DockerDaemonSuite.TestDaemonNoSpaceLeftOnDeviceError
19:43:44 
19:43:44 [d4117fe1e7275] waiting for daemon to start
19:43:44 [d4117fe1e7275] exiting daemon
19:43:44 docker_cli_daemon_test.go:1817:
19:43:44     s.d.Start(c, "--data-root", filepath.Join(testDir, "test-mount"))
19:43:44 /go/src/github.com/docker/docker/internal/test/daemon/daemon.go:203:
19:43:44     t.Fatalf("Error starting daemon with arguments: %v", args)
19:43:44 ... Error: Error starting daemon with arguments: [--data-root /tmp/no-space-left-on-device-test654916874/test-mount]
19:43:44

@thaJeztah thaJeztah mentioned this pull request Jun 19, 2018
Closed
cpuguy83
cpuguy83 approved these changes Jun 20, 2018
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit b29a0ab into moby:master Jun 20, 2018
@thaJeztah thaJeztah deleted the update_containerd_1.1.1.rc1 branch June 20, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justincormack justincormack justincormack approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@tianon tianon Awaiting requested review from tianon tianon is a code owner

Assignees
No one assigned
Labels
area/runtime impact/changelog status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thaJeztah @dmcgowan @justincormack @cpuguy83 @GordonTheTurtle