Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return "<unknown>" in /info response #37472

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

thaJeztah
Copy link
Member

The <unknown> string is presentation, and should be created by the CLI (if desirable); follow-up to #37451

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

[Docker Engine API v1.39](https://docs.docker.com/engine/api/v1.39/) documentation

* `GET /info` now returns an empty string, instead of `<unknown>` for `KernelVersion`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we don't explicitly document the <unknown> value, so perhaps this is all not needed

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@codecov
Copy link

codecov bot commented Jul 18, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@a5495f2). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #37472   +/-   ##
=========================================
  Coverage          ?   34.95%           
=========================================
  Files             ?      610           
  Lines             ?    44883           
  Branches          ?        0           
=========================================
  Hits              ?    15689           
  Misses            ?    27074           
  Partials          ?     2120

@thaJeztah
Copy link
Member Author

ping @tiborvass PTAL

Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

I'll do a self-five here, as it has two LGTM's an CI is green (ignoring codecov)

@thaJeztah thaJeztah merged commit 0a4f895 into moby:master Aug 16, 2018
@thaJeztah thaJeztah deleted the no_unknown branch August 16, 2018 12:56
@thaJeztah thaJeztah removed this from backlog in maintainers-session Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants