-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds LinuxMetadata support by default on Windows #37514
Conversation
1. Sets the LinuxMetadata flag by default on Windows LCOW v1 MappedDirectories. Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
@jhowardmsft - FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
@thaJeztah You any concerns with this? PPC seems stuck pending |
Codecov Report
@@ Coverage Diff @@
## master #37514 +/- ##
==========================================
+ Coverage 34.95% 35.44% +0.49%
==========================================
Files 610 610
Lines 44886 44886
==========================================
+ Hits 15690 15912 +222
+ Misses 27077 26814 -263
- Partials 2119 2160 +41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
MappedDirectories.
Signed-off-by: Justin Terry (VM) juterry@microsoft.com
- What I did
Added LinuxMetadata support for MappedDirectories on Windows LCOW v1.
- How I did it
RS4 added platform support for this in Windows. This adds the proper forwarding on these builds to enable it by default.
- How to verify it
Pre-Fix
Post-Fix (notice the chmod bits changed at runtime)
And it persists across runs!
- Description for the changelog
Adds LinuxMetadata support to all RS4+ LCOW v1 containers on Windows.
- A picture of a cute animal (not mandatory but encouraged)