Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds LinuxMetadata support by default on Windows #37514

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Adds LinuxMetadata support by default on Windows #37514

merged 1 commit into from
Jul 27, 2018

Conversation

jterry75
Copy link
Contributor

  1. Sets the LinuxMetadata flag by default on Windows LCOW v1
    MappedDirectories.

Signed-off-by: Justin Terry (VM) juterry@microsoft.com

- What I did
Added LinuxMetadata support for MappedDirectories on Windows LCOW v1.

- How I did it
RS4 added platform support for this in Windows. This adds the proper forwarding on these builds to enable it by default.

- How to verify it
Pre-Fix

> mkdir test
> echo test > test\test.log
> docker run -it -v <pwd>\test:/mnt/test alpine sh
/ # ls -al /mnt/test/test.log
-rwxrwxrwx    1 root     root             2 Jul 23 17:16 /mnt/test/test.log
/ # chmod 0700 /mnt/test/test.log
/ # ls -al /mnt/test/test.log
-rwxrwxrwx    1 root     root             2 Jul 23 17:16 /mnt/test/test.log
/ # exit
>

Post-Fix (notice the chmod bits changed at runtime)

> mkdir test
> echo test > test\test.log
> docker run -it -v <pwd>\test:/mnt/test alpine sh
/ # ls -al /mnt/test/test.log
-rwxrwxrwx    1 root     root             2 Jul 23 17:16 /mnt/test/test.log
/ # chmod 0700 /mnt/test/test.log
/ # ls -al /mnt/test/test.log
-rwx------    1 root     root             2 Jul 23 17:16 /mnt/test/test.log
/ # exit
>

And it persists across runs!

> docker run -it -v E:\docker\testshare:/mnt/test alpine sh
/ # ls -al /mnt/test/test.log
-rwx------    1 root     root             2 Jul 23 17:16 /mnt/test/test.log
/ # exit
>

- Description for the changelog

Adds LinuxMetadata support to all RS4+ LCOW v1 containers on Windows.

- A picture of a cute animal (not mandatory but encouraged)
Flameback Cichlid

1. Sets the LinuxMetadata flag by default on Windows LCOW v1
MappedDirectories.

Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
@jterry75
Copy link
Contributor Author

@jhowardmsft - FYI

Copy link
Member

@lowenna lowenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@lowenna
Copy link
Member

lowenna commented Jul 23, 2018

@rn @johnstep PTAL

@lowenna
Copy link
Member

lowenna commented Jul 25, 2018

@thaJeztah You any concerns with this? PPC seems stuck pending

@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

Merging #37514 into master will increase coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #37514      +/-   ##
==========================================
+ Coverage   34.95%   35.44%   +0.49%     
==========================================
  Files         610      610              
  Lines       44886    44886              
==========================================
+ Hits        15690    15912     +222     
+ Misses      27077    26814     -263     
- Partials     2119     2160      +41

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 13a8031 into moby:master Jul 27, 2018
@jterry75 jterry75 deleted the linux_metadata branch July 27, 2018 17:06
@thaJeztah thaJeztah added the area/lcow Issues and PR's related to the experimental LCOW feature label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants