Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] docker-py: use pip to install dependencies #38526

Closed
wants to merge 4 commits into from

Conversation

thaJeztah
Copy link
Member

follow-up to #38524

This makes sure that we have all the requirements installed and that they have the right version.

Moved the installation earlier in the Dockerfile, as docker-py is not so frequently updated in this repository, so optimizing for caching.

Removed all the apt-packages that are not needed.

@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #38526 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #38526      +/-   ##
==========================================
+ Coverage   36.64%   36.71%   +0.07%     
==========================================
  Files         608      608              
  Lines       45173    45230      +57     
==========================================
+ Hits        16553    16608      +55     
+ Misses      26339    26333       -6     
- Partials     2281     2289       +8

@olljanat
Copy link
Contributor

PowerPC failure looks like related.

@olljanat
Copy link
Contributor

olljanat commented Jan 10, 2019

(reserved for my derek commands)

@derek derek bot added the status/failing-ci Indicates that the PR in its current state fails the test suite label Jan 10, 2019
@cpuguy83
Copy link
Member

Nice, I wonder if we can go even further and install docker-py deps into their own image and then COPY them in at the end.

pip install --target would allow us to customize the path at least or can just use the default path.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This makes sure that we have all the requirements installed
and that they have the right version.

Moved the installation earlier in the Dockerfile, as
docker-py is not so frequently updated in this repository,
so optimizing for caching.

Removed all the apt-packages that are not needed.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
We only run these tests on x86, so skip for other architectures

This is a dirty hack, until we start using BuildKit, at whith time
we'll be able to skip stages.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@derek derek bot added rebuild/janky and removed status/failing-ci Indicates that the PR in its current state fails the test suite labels Jan 11, 2019
@kolyshkin
Copy link
Contributor

I would argue that using distro packages should be preferred to using pip -- distro packages are faster to install and (supposedly?) better maintained so more stable. The current approach is to install as much as we can from the distro packages, and use pip for the rest.

The only downside I see is packages to be installed are spread between two places in Dockerfile, and it's not bad enough per se to switch to pip entirely. @thaJeztah perhaps I'm missing something -- what is your motivation to prefer pip to apt install?

@thaJeztah
Copy link
Member Author

Closing this in favour of #39068

@thaJeztah thaJeztah closed this Apr 13, 2019
@thaJeztah thaJeztah deleted the use_pip_for_docker_py branch April 13, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants