New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] docker-py: use pip to install dependencies #38526
Conversation
182fe8e
to
9b6fd2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #38526 +/- ##
==========================================
+ Coverage 36.64% 36.71% +0.07%
==========================================
Files 608 608
Lines 45173 45230 +57
==========================================
+ Hits 16553 16608 +55
+ Misses 26339 26333 -6
- Partials 2281 2289 +8 |
PowerPC failure looks like related. |
(reserved for my derek commands) |
Nice, I wonder if we can go even further and install docker-py deps into their own image and then
|
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This makes sure that we have all the requirements installed and that they have the right version. Moved the installation earlier in the Dockerfile, as docker-py is not so frequently updated in this repository, so optimizing for caching. Removed all the apt-packages that are not needed. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
9b6fd2a
to
62878ae
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
a3eaf17
to
141d867
Compare
We only run these tests on x86, so skip for other architectures This is a dirty hack, until we start using BuildKit, at whith time we'll be able to skip stages. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
I would argue that using distro packages should be preferred to using pip -- distro packages are faster to install and (supposedly?) better maintained so more stable. The current approach is to install as much as we can from the distro packages, and use pip for the rest. The only downside I see is packages to be installed are spread between two places in Dockerfile, and it's not bad enough per se to switch to pip entirely. @thaJeztah perhaps I'm missing something -- what is your motivation to prefer pip to apt install? |
Closing this in favour of #39068 |
follow-up to #38524
This makes sure that we have all the requirements installed and that they have the right version.
Moved the installation earlier in the Dockerfile, as docker-py is not so frequently updated in this repository, so optimizing for caching.
Removed all the apt-packages that are not needed.