Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor Microsoft/hcsshim@ba3d6667 #38959

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Conversation

lowenna
Copy link
Member

@lowenna lowenna commented Mar 27, 2019

Signed-off-by: John Howard jhoward@microsoft.com

Bumps Microsoft/hcsshim to pick up some sync issues around waiting for process/system termination.

@jterry75 FYI (and PTAL). Have verified locally that both RS1 and RS5 argon CI passes.

Signed-off-by: John Howard <jhoward@microsoft.com>
@lowenna
Copy link
Member Author

lowenna commented Mar 28, 2019

@thaJeztah - this is probably an important one for 1903. @jterry75 concur?

@andrewhsu andrewhsu mentioned this pull request Mar 28, 2019
4 tasks
@thaJeztah
Copy link
Member

Linking this from #38956

Note that we might be fast-forwarding the 19.03 branch instead of cherry-picking (if no "features" are merged into master); see docker-archive#184 (comment)

@jterry75
Copy link
Contributor

@jhowardmsft - Yes it would be ideal.

Note however that Docker is not hitting this lock today because I assume it has exactly one call to Wait* for any given system/process handle. For Docker's case this is more of a nice fix to have. And for Docker on libcontainerd this is a binary dependency so again, not totally required.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Experimental failure is unrelated (tracked through #38963)

@thaJeztah
Copy link
Member

ping @johnstep @tiborvass PTAL

@tiborvass tiborvass merged commit 32157f9 into moby:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants