Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump docker/go-units v0.4.0 #39128

Merged
merged 1 commit into from Apr 24, 2019
Merged

bump docker/go-units v0.4.0 #39128

merged 1 commit into from Apr 24, 2019

Conversation

thaJeztah
Copy link
Member

@thaJeztah
bump docker/go-units v0.4.0
c782aef 
relevant changes:

- docker/go-units#33 Fix handling of unlimited (-1) ulimit values
- docker/go-units#34 Revert 46 minute threshold

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ping @vdemeester @AkihiroSuda

vdemeester
vdemeester approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

AkihiroSuda
AkihiroSuda approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green

@thaJeztah
Copy link
Member Author

experimental failing on a flaky;

05:54:42 FAIL: docker_api_swarm_test.go:292: DockerSwarmSuite.TestAPISwarmLeaderElection
05:54:42

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #39128 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #39128      +/-   ##
==========================================
+ Coverage   37.03%   37.04%   +<.01%     
==========================================
  Files         612      612              
  Lines       45400    45400              
==========================================
+ Hits        16813    16817       +4     
+ Misses      26301    26299       -2     
+ Partials     2286     2284       -2

@AkihiroSuda AkihiroSuda merged commit ac48309 into moby:master Apr 24, 2019
@thaJeztah thaJeztah deleted the bump_go_units branch April 24, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
status/4-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thaJeztah @vdemeester @AkihiroSuda @GordonTheTurtle