New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated mkimage-arch.sh #39165
Updated mkimage-arch.sh #39165
Conversation
* reset umask to 022 * introduced PKGREQUIRED * introduced PKGREMOVE - to be able to remove linux etc on Parabola GNU/Linux * updated PKGIGNORE - cryptsetup & device-mapper removed to not break the installation - added not required packages * force link /etc/localtime * install pacman-mirrorlist Signed-off-by: Staf Wagemakers <staf@wagemakers.be>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some quick comments about code formatting
ping @tianon could you have a look at the changes itself?
Signed-off-by: Staf Wagemakers <staf@wagemakers.be>
Thanks for updating! I'm not familiar with this script myself, so I'll wait for @tianon to have a look (who, I think is more familiar with it 🤗) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @tianon, I'll follow your lead ❤️
LGTM
- What I did
Updated mkimage-arch.sh
- How I did it
- How to verify it
run ./mkimage-arch.sh
- Description for the changelog
Updated mkimage-arch.sh
Signed-off-by: Staf Wagemakers staf@wagemakers.be