Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mkimage-arch.sh #39165

Merged
merged 2 commits into from Jul 17, 2019
Merged

Updated mkimage-arch.sh #39165

merged 2 commits into from Jul 17, 2019

Conversation

stafwag
Copy link
Contributor

@stafwag stafwag commented May 1, 2019

- What I did
Updated mkimage-arch.sh

- How I did it

  • reset umask to 022
  • introduced PKGREQUIRED
  • introduced PKGREMOVE
    • to be able to remove linux etc on Parabola GNU/Linux
  • updated PKGIGNORE
    • cryptsetup & device-mapper removed to not break the installation
    • added not required packages
  • force link /etc/localtime
  • install pacman-mirrorlist

- How to verify it
run ./mkimage-arch.sh

- Description for the changelog
Updated mkimage-arch.sh

Signed-off-by: Staf Wagemakers staf@wagemakers.be

* reset umask to 022
* introduced PKGREQUIRED
* introduced PKGREMOVE
  - to be able to remove linux etc on Parabola GNU/Linux
* updated PKGIGNORE
  - cryptsetup & device-mapper removed to not break the installation
  - added not required packages
* force link /etc/localtime
* install pacman-mirrorlist

Signed-off-by: Staf Wagemakers <staf@wagemakers.be>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some quick comments about code formatting

ping @tianon could you have a look at the changes itself?

contrib/mkimage-arch.sh Outdated Show resolved Hide resolved
contrib/mkimage-arch.sh Outdated Show resolved Hide resolved
contrib/mkimage-arch.sh Outdated Show resolved Hide resolved
Signed-off-by: Staf Wagemakers <staf@wagemakers.be>
@thaJeztah
Copy link
Member

Thanks for updating! I'm not familiar with this script myself, so I'll wait for @tianon to have a look (who, I think is more familiar with it 🤗)

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tianon, I'll follow your lead ❤️

LGTM

@thaJeztah thaJeztah merged commit 08191c3 into moby:master Jul 17, 2019
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants