Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed the issue where the daemon kept running even when
dockerd-rootless.sh
(and its descendent) was killed.The causes of the issue were:
Pdeathsig
, but it was invalidated after runningnewuidmap
(Support new pid namespace or ability to kill all children rootless-containers/rootlesskit#65)dockerd-rootless.sh
had invokedrootlesskit
anddockerd
without setting up trap for propagating signals- How I did it
dockerd-rootless.sh
toexec
the processes without forking- How to verify it
- Description for the changelog
rootless: fix killing daemon
- A picture of a cute animal (not mandatory but encouraged)
https://twitter.com/13033303/status/1128454769050128384