Fix seccomp profile for clone syscall #39308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @justincormack @KentaTada @estesp ptal |
|
@thaJeztah I think below example.json should also be modified. Thanks! |
KentaTada
pushed a commit
to KentaTada/runc
that referenced
this pull request
Jun 4, 2019
This commit changes the value of seccomp test for clone syscall. Also hardcoded values should be changed because it is unclear to understand what flags are tested. Related issues: * containerd/containerd#3314 * moby/moby#39308 * opencontainers/runtime-tools#694 Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
KentaTada
pushed a commit
to KentaTada/runc
that referenced
this pull request
Jun 4, 2019
This commit changes the value of seccomp test for clone syscall. Also hardcoded values should be changed because it is unclear to understand what flags are tested. Related issues: * containerd/containerd#3314 * moby/moby#39308 * opencontainers/runtime-tools#694 Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
justincormack
approved these changes
Jun 4, 2019
|
Let me update that fixture used in the test |
All clone flags for namespace should be denied. Based-on-patch-by: Kenta Tada <Kenta.Tada@sony.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
fix_clone_seccomp_cgroupns
branch
from
b719c17
to
a1ec855
Compare
|
updated 👍 |
Codecov Report
@@ Coverage Diff @@
## master #39308 +/- ##
=========================================
Coverage ? 37.03%
=========================================
Files ? 612
Lines ? 45486
Branches ? 0
=========================================
Hits ? 16848
Misses ? 26353
Partials ? 2285 |
|
failures look unrelated |
mauriciovasquezbernal
pushed a commit
to kinvolk/runc
that referenced
this pull request
Jul 23, 2019
This commit changes the value of seccomp test for clone syscall. Also hardcoded values should be changed because it is unclear to understand what flags are tested. Related issues: * containerd/containerd#3314 * moby/moby#39308 * opencontainers/runtime-tools#694 Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
adrianreber
pushed a commit
to adrianreber/runc
that referenced
this pull request
Aug 6, 2019
This commit changes the value of seccomp test for clone syscall. Also hardcoded values should be changed because it is unclear to understand what flags are tested. Related issues: * containerd/containerd#3314 * moby/moby#39308 * opencontainers/runtime-tools#694 Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Dec 31, 2019
This commit changes the value of seccomp test for clone syscall. Also hardcoded values should be changed because it is unclear to understand what flags are tested. Related issues: * containerd/containerd#3314 * moby/moby#39308 * opencontainers/runtime-tools#694 Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on containerd/containerd#3314
All clone flags for namespace should be denied.