-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update modules to support riscv64 #39423
Conversation
@carlosedp you inadvertently added the dockerd binary in the PR. |
My bad, it fell into the cracks together with all the files. Should be removed now. |
@carlosedp the vendor check failed, you've got to vendor this way:
|
Please sign your commits following these rules: $ git clone -b "riscv64" git@github.com:carlosedp/moby.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354512336
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
Codecov Report
@@ Coverage Diff @@
## master #39423 +/- ##
=========================================
Coverage ? 37.33%
=========================================
Files ? 609
Lines ? 45197
Branches ? 0
=========================================
Hits ? 16875
Misses ? 26034
Partials ? 2288 |
@tiborvass Why when I deleted whole When I ran inside the shell, the difference was that some go.mod files were deleted. |
@carlosedp probably vndr version differences, that's why we pin the vndr version in the dockerfile so that everyone agrees on how to vendor. |
reminds me that we need to debug why updating to the latest vndr version causes CI to fail; #39216 |
oh; before we merge this one, could we merge #39054 ? in case we want to backport that one (without introducing the new things from the other bumps) we also might want to ask if they can tag a new version for netlink |
Let's also get #39216 first, it includes a vndr that has riscv64 support (LK4D4/vndr#80) I can rebase this PR then. |
@carlosedp I updated your PR. One notable difference is that the netns commit was 13995c7128ccc8e51e9a6bd2b551020a27180abd which didn't include the riscv changes from vishvananda/netns#34. So I updated it to 7109fa855b0ff1ebef7fbd2f6aa613e8db7cfbc0. |
Amazing. Thanks @tiborvass. Now the vndr I used standalone would work fine since the CI have been updated as well right? |
@carlosedp most likely, but I'd still recommend using For the record, I couldn't figure out this: #39423 (comment) |
After updating libnetwork it failed building. I saw the latest libnetwork update required a new sctp too. |
Ugh, forgot to include moby/libnetwork#2412 so I updated libnetwork as well. |
vendor check is failing @tiborvass |
Signed-off-by: CarlosEDP <me@carlosedp.com>
@thaJeztah what are you talking about? 👀 😛jk updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Signed-off-by: CarlosEDP me@carlosedp.com
Updating projects using libraries that were recently updated to support Risc-V architecture.
Go upstream work is tracked on: golang/go#27532
Risc-V software support tracker on https://github.com/carlosedp/riscv-bringup