Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra permission check in removal test #39591

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Add extra permission check in removal test #39591

merged 1 commit into from
Jul 26, 2019

Conversation

crosbymichael
Copy link
Contributor

Signed-off-by: Michael Crosby crosbymichael@gmail.com

@crosbymichael
Add extra permission check in removal test
d6cbeee 
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
thaJeztah
thaJeztah approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin ptal

@thaJeztah thaJeztah added this to In progress in Improving CI via automation Jul 22, 2019
@crosbymichael
Copy link
Contributor Author

ping

@thaJeztah
Copy link
Member

we might want to disable this docker-py test; looks flaky https://jenkins.dockerproject.org/job/Docker-PRs/54995/console

14:03:14 _______________ ExecDemuxTest.test_exec_command_tty_stream_demux _______________

14:03:14 tests/integration/api_exec_test.py:324: in test_exec_command_tty_stream_demux

14:03:14     assert (b'hello out\r\n', None) in exec_log

14:03:14 E   AssertionError: assert (b'hello out\r\n', None) in [(b'hello out\r\nhello err\r\n', None)]

@thaJeztah
Copy link
Member

@cpuguy83 @kolyshkin PTAL

Improving CI automation moved this from In progress to Reviewer approved Jul 26, 2019
cpuguy83
cpuguy83 approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

all green now; merging

@thaJeztah thaJeztah merged commit 9f122f0 into moby:master Jul 26, 2019
Improving CI automation moved this from Reviewer approved to Done Jul 26, 2019
@crosbymichael crosbymichael deleted the perm-test branch July 26, 2019 16:44
@thaJeztah thaJeztah mentioned this pull request Sep 25, 2019
Closed
4 tasks
@thaJeztah
Copy link
Member

relates to #39193, which added this code

@thaJeztah thaJeztah mentioned this pull request Jan 25, 2020
Closed
4 tasks
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
area/testing process/cherry-picked status/2-code-review
Projects
Improving CI
  
Done
Milestone
20.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crosbymichael @thaJeztah @cpuguy83 @GordonTheTurtle