Fix docker crash when creating namespaces with UID in /etc/subuid and /etc/subgid #39764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wondering if we should do all this magic, or just detect numeric IDs and produce an informative error that username should be used 🤔 |
|
@thaJeztah Not sure if we want to ask user to change |
AkihiroSuda
approved these changes
Nov 1, 2019
|
needs a rebase to get the new jenkinsfile to run today's PR checks. triggering of old jenkins job will not work anymore |
… /etc/subgid This fix tries to address the issue raised in 39353 where docker crash when creating namespaces with UID in /etc/subuid and /etc/subgid. The issue was that, mapping to `/etc/sub[u,g]id` in docker does not allow numeric ID. This fix fixes the issue by probing other combinations (uid:groupname, username:gid, uid:gid) when normal username:groupname fails. This fix fixes 39353. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
39353-subgid-subuid
branch
from
9969519
to
f09dc2f
Compare
|
Rebased and all tests passed. Thanks all 🎉 ! |
|
Thanks! |
thaJeztah
added
area/security/userns
impact/changelog
and removed
rebuild/windowsRS1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix tries to address the issue raised in #39353 where docker crash when creating namespaces with UID in /etc/subuid and /etc/subgid.
The issue was that, mapping to
/etc/sub[u,g]idin docker does not allow numeric ID.This fix fixes the issue by probing other combinations (uid:groupname, username:gid, uid:gid) when normal username:groupname fails.
This fix fixes #39353.
Signed-off-by: Yong Tang yong.tang.github@outlook.com