New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GetStatus(), GetTable() to return multi-line tables #39834
Conversation
/cc @rhvgoyal ptal |
ping @kolyshkin PTAL |
@trgill looks like build is failing;
|
a82da7f
to
daf43da
Compare
@trgill this code is not compileable, please fix:
|
daf43da
to
764a1a3
Compare
Device mapper target tables may have multiple lines. When the table has multiple lines, it is required that dm_get_next_target(ptr) be called until the returned pointer is Nil. Examples of using dm_get_next_target() can be found in libdm/dm-tools/dmsetup.c Update GetStatus and GetTable to fetch and return more than just the first line of the DM table. Added TargetLine type to represent a single line of the DM table. An array of TargetLine is used to return the full table. Update getThinPoolDataMetaMajMin() to hanle an array of TargetLine. Signed-off-by: Todd Gill <tgill@redhat.com>
764a1a3
to
01a003c
Compare
@kolyshkin fixed. Looks like a couple unit tests TestDevmapperReduceLoopBackSize and TestDevmapperIncreaseLoopBackSize are failing. I'll have a look to see if I introduced the problem. |
I don't think the test failures are related to this change. The log entries after the failures indicate:
|
The devicemapper storage-driver was deprecated, and has been removed, so closing issues related to this storage-driver. See; |
fixes #39833
Device mapper target tables may have multiple lines. When the table has
multiple lines, it is required that dm_get_next_target(ptr) be called
until the returned pointer is Nil. Examples of using dm_get_next_target()
can be found in libdm/dm-tools/dmsetup.c
- What I did
Update GetStatus and GetTable to fetch and return more than just the first
line of the DM table.
- How I did it
Added TargetLine type to represent a single line of the DM table. An
array of TargetLine is used to return the full table.
Update getThinPoolDataMetaMajMin() to hanle an array of TargetLine.
- How to verify it
Create a multi-line DM target
Call GetStatus() and GetTable() with/without the fix
- Description for the changelog
Fix GetStatus(), GetTable() to return multi-line tables